Change patch reload to fully reload the content pack#1200
Open
SinZ163 wants to merge 1 commit into
Open
Conversation
This enables the reload command to work on ConfigSchema, CustomLocations, Token Aliases and Dynamic Tokens
SinZ163
changed the title
patch reload to fully reload the content pack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the reload command to work on ConfigSchema, CustomLocations, Token Aliases and Dynamic Tokens
https://youtu.be/TGmLqEWS7T4
The changes in PatchLoader and PatchManager are technically unrelated but is for a separate issue where if a patch is permanently disabled from being invalid, patch reload doesn't remove it. This fixes the common case where you invalidate the entire content pack, but not the lesser case when invalidating a specific patch and its descendents.