Skip to content

add rename broadcasts addon back - #216

Open
PuzzlingGGG wants to merge 1 commit into
PenguinMod:developfrom
PuzzlingGGG:develop
Open

add rename broadcasts addon back#216
PuzzlingGGG wants to merge 1 commit into
PenguinMod:developfrom
PuzzlingGGG:develop

Conversation

@PuzzlingGGG

Copy link
Copy Markdown

Resolves

  • Resolves what someone said in the discord

Proposed Changes

adds back the "rename broadcasts" addon back, it was removed for some reason and its just useful

Reason for Changes

its a useful addon that was removed for some reason

Test Coverage

i renamed a few broadcasts in joe simulator and it worked

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@Steve0Greatness Steve0Greatness left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there shouldn't be licensing concerns, given we already share license with upstream. Only issue I have is that it'd be nice if you added Garbo as a co-author or marked him as the primary author of this commit; but that's just for the sake of the commit history being nice.

@PuzzlingGGG

Copy link
Copy Markdown
Author

i don't know how to do that, i use the github ui for commits....

@Steve0Greatness

Copy link
Copy Markdown

i don't know how to do that, i use the github ui for commits....

Shoot meant to say something a bit earlier: https://docs.github.com/en/pull-requests/how-tos/commit-changes/creating-a-commit-with-multiple-authors.

Gist is: add Co-authored-by: Name <email> to your commit (if you don't know their email, use the commiting email, which you can find by adding .patch to the end of a commit URL, not in PRs it seems, though)

In your case, you'll be looking at 3cfba04, so you'll find it at https://github.com/PenguinMod/penguinmod.github.io/commit/3cfba04.patch

So here you'd likely be adding Co-authored-by: GarboMuffin <muffin@mailbox.org> to the end of your message. It'd be preferable if GitHub had the ability to set primary authorship in the web UI, but it doesn't for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants