add rename broadcasts addon back - #216
Conversation
Steve0Greatness
left a comment
There was a problem hiding this comment.
I think there shouldn't be licensing concerns, given we already share license with upstream. Only issue I have is that it'd be nice if you added Garbo as a co-author or marked him as the primary author of this commit; but that's just for the sake of the commit history being nice.
|
i don't know how to do that, i use the github ui for commits.... |
Shoot meant to say something a bit earlier: https://docs.github.com/en/pull-requests/how-tos/commit-changes/creating-a-commit-with-multiple-authors. Gist is: add In your case, you'll be looking at So here you'd likely be adding |
Resolves
Proposed Changes
adds back the "rename broadcasts" addon back, it was removed for some reason and its just useful
Reason for Changes
its a useful addon that was removed for some reason
Test Coverage
i renamed a few broadcasts in joe simulator and it worked
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet