Capture external dynamic lib in Win builds for LQ#1396
Draft
mlxd wants to merge 4 commits into
Draft
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
- Coverage 98.23% 91.36% -6.88%
==========================================
Files 275 204 -71
Lines 38913 27359 -11554
==========================================
- Hits 38228 24997 -13231
- Misses 685 2362 +1677
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: The Lightning dynamic runtime library for Catalyst currently builds for Linux and MacOS platforms, with all pathways for Windows excluded. This PR opens those pathways to: 1) generate a dynamic library and 2) exposes the symbols using Windows-expected formats.
Description of the Change: Create a pathway for building the Catalyst Lightning runtime plugin on Windows systems.
Benefits:
Possible Drawbacks:
Related GitHub Issues/PRs: PennyLaneAI/catalyst#2976