Skip to content

fix: declare Perl::Critic < 1.122 as incompatible via x_breaks #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: declare Perl::Critic < 1.122 as incompatible via x_breaks #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fbf075
add TODO test for x_breaks metadata declaration
toddr-bot Apr 27, 2026
c92abb6
declare Perl::Critic < 1.122 as incompatible via x_breaks
toddr-bot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dist.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Task::Weaken = 0
[Prereqs / TestRequires]
Test::More = 0.96

[Breaks]
Perl::Critic = < 1.122

[DynamicPrereqs]
-body = requires('File::Spec', is_os('MSWin32') ? '3.2701' : '0.84');
-body = requires('IO::String') if $] < '5.008000';
Expand Down Expand Up @@ -64,6 +67,7 @@ filename = xt/author/kwalitee.t
:version = 0.022
verify_prereqs = 1
version_extractor = ExtUtils::MakeMaker
[Test::CheckBreaks]
[Test::Portability]
;[Test::CleanNamespaces]

Expand Down
20 changes: 20 additions & 0 deletions xt/author/check-breaks.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
use strict;
use warnings;

use Test::More 0.88;

use CPAN::Meta 2.120900;

SKIP: {
skip 'no META.json in source tree (requires dzil build)', 1
if not -f 'META.json';

my $meta = CPAN::Meta->load_file('META.json');
my $breaks = $meta->custom('x_breaks') || {};

ok( exists $breaks->{'Perl::Critic'},
'x_breaks declares Perl::Critic < 1.122 (incompatible with PPI >= 1.218 operator token changes)'
);
}

done_testing;
Loading