Add support tasks which can be used to share work with other threads that are e.g. waiting for a mutex#3159
Draft
IntegratedQuantum wants to merge 2 commits into
Draft
Conversation
…that are e.g. waiting for a mutex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main motivation for this is poor debug mode load times, and generally poor thread utilization. Currently NoiseBasedVoronoi and CaveBiomeMapGen are basically single-threaded at the start of the game, since every chunk needs to wait on them.
This PR adds support tasks, which allow threads to share their workload with other threads in a more fine-grained way.
e.g. one could imagine a mutex type that tries to run support tasks before blocking.
fixes #107