Use a fixed rate to correct the bandwidth used by congestion control#3191
Open
IntegratedQuantum wants to merge 1 commit into
Open
Use a fixed rate to correct the bandwidth used by congestion control#3191IntegratedQuantum wants to merge 1 commit into
IntegratedQuantum wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was observed that connections with low RTT could starve connections with high RTT. This happens because low RTT connections could increment their bandwidth faster after a loss happens.
This is fixed here by making the increment RTT-independent, it now is set to a fixed value of 100 kB/s per second (which is the increment a 50 ms connection had in the previous code).
I tested this on the server side in the last play session and I didn't see any issues.