GuiWindow based tooltips#3242
Open
Wunka wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not resolving: #2312
With more and more disabled buttons (for example: #3238). I think Buttons need a tooltip to render why they are disabled. As I didn't want to do everything which is in #2312. I took the for now easier route,
getTooltiponGuiWindowsinstead of on items only.This PR can be kinda seen (if needed even split into seperate PRs) as two things.
getTooltipon windows and move the rendering of tooltips around.disabledReasonvariable to buttons which will be shown in the tooltip of buttons if they are disabled. (Also added two example texts)