Fix in PCLVisualizer::convertPointCloudToVTKPolyData: do not re-use v…#6440
Open
mvieth wants to merge 2 commits into
Open
Fix in PCLVisualizer::convertPointCloudToVTKPolyData: do not re-use v…#6440mvieth wants to merge 2 commits into
mvieth wants to merge 2 commits into
Conversation
…ertices vtkPolyData::SetVerts checks if the given vertices are different from the ones that vtkPolyData already has, and only then it updates some internal data structures (see also https://github.com/Kitware/VTK/blob/9ca1503e1c3c65c571ebd256d2aeabf777944ad6/Common/DataModel/vtkPolyData.cxx#L427 ). This means, if we call GetVerts(), and vtkPolyData returns some existing vertices, which we then modify and pass to SetVerts(), there is no guarantee that the internal data structures of vtkPolyData are all correctly updated. The fix is that we do not call GetVerts(), instead we always recreate the vertices array from scratch.
mvieth
added
module: visualization
changelog: fix
If we remove it, a visualization test segfaults for VTK 7. Also, as far as I can say, the bug that we try to fix by removing GetVerts(), does not even occurr in VTK 7. So: VTK 9 and newer: remove GetVerts() to fix the bug. VTK 8 and older: leave everything as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ertices
vtkPolyData::SetVerts checks if the given vertices are different from the ones that vtkPolyData already has, and only then it updates some internal data structures (see also https://github.com/Kitware/VTK/blob/9ca1503e1c3c65c571ebd256d2aeabf777944ad6/Common/DataModel/vtkPolyData.cxx#L427 ). This means, if we call GetVerts(), and vtkPolyData returns some existing vertices, which we then modify and pass to SetVerts(), there is no guarantee that the internal data structures of vtkPolyData are all correctly updated. The fix is that we do not call GetVerts(), instead we always recreate the vertices array from scratch.
Fixes #6434