fix(data): track combo costs and pagination limits - #270
Open
kartojal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decimalfieldsstart/endwindows and cover sync/async pagination boundariesValidation
make check(lint, format, Pyright, 2,271 non-integration tests)make buildLinear: DEV-437
Note
Low Risk
Additive model fields and client-side pagination guards; behavior change is failing early with UserInputError instead of a rejected API call when offset limits are exceeded.
Overview
Adds
gross_entry_cost_usdcandentry_fees_usdconComboPositionas optionalDecimalfields (with parsing tests), so combo entry cost breakdown matches the Data API.Introduces
max_offsetonOffsetPaginatedSpecand checks it in sync/async offset pagination before HTTP: trades cap at 10,000, activity at 5,000, raisingUserInputErrorwith guidance to narrow viastart/end. Public and secure clientlist_trades/list_activitydocstrings document those limits; unit tests assert spec limits and boundary rejection without extra requests.Reviewed by Cursor Bugbot for commit 5467ac2. Bugbot is set up for automated code reviews on this repo. Configure here.