improvement: map max_completion_tokens to max_tokens for Groq and Cerebras#1633
Open
Jwrede wants to merge 1 commit into
Open
improvement: map max_completion_tokens to max_tokens for Groq and Cerebras#1633Jwrede wants to merge 1 commit into
Jwrede wants to merge 1 commit into
Conversation
…ebras
Groq and Cerebras APIs use max_tokens, not max_completion_tokens.
Other providers like Deepinfra and Fireworks already have this mapping.
Add it to Groq (via existing extra params) and Cerebras (using {} for
defaultValues per review feedback on Portkey-AI#1516).
Closes Portkey-AI#1341
Author
|
Friendly ping @VisargD -- this has been open ~7 days. Commits are signed per repo requirements. Let me know if anything needs changing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
max_completion_tokenstomax_tokensfor Groq and Cerebras providersmax_tokens, notmax_completion_tokensCloses #1341
Supersedes #1516 (stale since March, maintainer feedback unaddressed)
Changes
src/providers/groq/index.ts: Addedmax_completion_tokensentry to the existing extra params objectsrc/providers/cerebras/index.ts: Added third argument tochatCompleteParams()withmax_completion_tokensmapping, using{}for defaultValues (per review feedback on feat: Add mapping for max_tokens for groq and cerebras #1516)Tests Run
npm run build)npm run format:check)Type of Change