fix: relocate akto and zscaler plugins into src/plugins/ (Linux build fix)#1661
Open
stochastic-sisyphus wants to merge 1 commit into
Open
Conversation
PR Portkey-AI#1548 (akto) and PR Portkey-AI#1514 (zscaler) placed their plugin directories at repo-root plugins/ instead of src/plugins/, where every other plugin lives and where src/plugins/index.ts imports them from: import { handler as aktoScan } from './akto/scan'; import { handler as zscalerGuardrails } from './zscaler/zscalerprotect'; Linux Docker builds fail with: RollupError: Could not resolve "./akto/scan" from "src/plugins/index.ts" Move both plugin directories under src/plugins/ to match the existing layout and unblock self-hosted Linux builds.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/akto/→src/plugins/akto/plugins/zscaler/→src/plugins/zscaler/plugins/directory.Why
PRs #1548 (akto) and #1514 (zscaler) were merged with their plugin
directories at repo-root
plugins/instead ofsrc/plugins/, whereevery other plugin lives and where
src/plugins/index.tsimportsthem from (lines 73-74):
Linux Docker builds of branch
2.0.0fail atnpm run buildwith:Test plan
docker build -t portkeyai/gateway:2.0.0 .succeeds on Linux (verified locally after combining with sibling PR for realtimeLLMEventParser case rename).