Tamashii: accept the itch.io executable name - #2645
Open
Roger13 wants to merge 1 commit into
Open
Conversation
The launch script only tested for gamedata/game.exe, which is the Steam build's name. The itch.io release ships tamashii.exe, so 7zzs never ran, no data.win was produced, and gmloader exited with 'Unable to open game's WAD file'. Pick the first *.exe in gamedata instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Roger13
requested review from
Cebion,
Dia2809,
Fraxinus88,
Ganimoth,
ImCoKeMaN,
JanTrueno,
Slayer366,
beniamino38,
bmdhacks,
cdeletre and
kloptops
as code owners
August 27, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tamashii.shtests for one exact filename:game.exeis the Steam build's name. The itch.io release shipstamashii.exe. With the itch.io copy the test never matches,7zzsnever runs, nodata.winappears, and the latermv gamedata/data.win gamedata/game.droidis skipped. The script then launchesgmloaderwith no data file:The port's own
port.jsonlinks the itch.io store page, so the itch.io build is an expected source.Fix
Pick the first
*.exeingamedatainstead of hardcoding the name. Steam and itch.io copies both work, and the removal list drops the same file that was extracted.Notes
ls ... 2>/dev/nullmatches the style already used a few lines below for the.oggcheck..exepresent:gameexeis empty,[ -f "" ]is false,rm -f ""is a no-op. Same behaviour as before.game.exeandtamashii.exepresent:game.exewins, as before.bash -nclean.Testing
Reported and reproduced on RG35XX-H (H700) at 640x480 with the itch.io build; the log above is from that device. I could not run the full distribution matrix. The change touches only filename selection, not rendering, input or libraries, so behaviour on other CFWs should be unchanged — the Steam path is byte-identical in effect. Happy to hold for someone with wider hardware access to confirm.