Skip to content

Use gunzipSync to avoid uncaught async zlib errors #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rom1504 merged 1 commit into from
Apr 1, 2026
Merged

Use gunzipSync to avoid uncaught async zlib errors #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions nbt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,9 @@ const hasBedrockLevelHeader = (data) =>
async function parseAs (data, type, options = {}) {
if (!(data instanceof Buffer)) throw new Error('Invalid argument: `data` must be a Buffer object')
if (hasGzipHeader(data)) {
data = await new Promise((resolve, reject) => {
zlib.gunzip(data, (error, uncompressed) => {
if (error) reject(error)
else resolve(uncompressed)
})
})
// Use sync to avoid uncaught async zlib errors from Node's C++ binding
// race condition during teardown. See nodejs/node#62325, nodejs/node#61202
data = zlib.gunzipSync(data)
}

protos[type].setVariable('noArraySizeCheck', options.noArraySizeCheck)
Expand Down
Loading