Bump mediawiki-codesniffer to ^52 to unblock Composer - #938
Merged
Conversation
Composer refuses to install the phpcs 3.6.2 that codesniffer 39.0.0 pins, because of advisory PKSA-rdkp-vv9z-mjkg. Only the Code style and PHPStan jobs were affected, as they are the ones running Composer inside the extension directory. Codesniffer 52 needs PHP 8.3 and the plugin that registers PHPCSExtra. Of the new findings, five sniffs are excluded, each mirroring an exclusion already in phpcs.xml: Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace (12), Generic.CodeAnalysis.AssignmentInCondition (11), Universal.WhiteSpace.CommaSpacing (8), Squiz.WhiteSpace.FunctionOpeningBraceSpace.SpacingAfter (3) and MediaWiki.WhiteSpace.SpaceAfterClosure.NoWhitespaceAfterArrow (2). Two are fixed in tests: an implicit nullable parameter type and an assertEquals over two counts. phpcs no longer sniffs JavaScript, where its tokenizer misreads the nesting in JQueryLeafletTest.js. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer refuses to install the phpcs 3.6.2 that codesniffer 39.0.0 pins, because of advisory
PKSA-rdkp-vv9z-mjkg. Only the Code style and PHPStan jobs were affected, as they are the ones
running Composer inside the extension directory. Codesniffer 52 needs PHP 8.3 and the plugin
that registers PHPCSExtra.
Of the new findings, five sniffs are excluded, each mirroring an exclusion already in phpcs.xml:
Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace(12),Generic.CodeAnalysis.AssignmentInCondition(11),Universal.WhiteSpace.CommaSpacing(8),Squiz.WhiteSpace.FunctionOpeningBraceSpace.SpacingAfter(3) andMediaWiki.WhiteSpace.SpaceAfterClosure.NoWhitespaceAfterArrow(2). Two are fixed in tests: animplicit nullable parameter type and an
assertEqualsover two counts. phpcs no longer sniffsJavaScript, where its tokenizer misreads the nesting in
JQueryLeafletTest.js.