Lead the login form with the code login - #40
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
============================================
+ Coverage 87.37% 87.71% +0.34%
- Complexity 628 634 +6
============================================
Files 71 71
Lines 2210 2239 +29
============================================
+ Hits 1931 1964 +33
+ Misses 279 275 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The login form now leads with the member route on wikis that offer the code route. The address box and "Continue with email" come first, that button is the form's primary one, focus lands in the address box, and the password form follows under a divider reading "or log in with a password" in place of "or". Enter submits whatever was filled in: an address asks for a code, a password logs in. The account creation form and the code entry screen are untouched. Done in the form description rather than site CSS, which would move the boxes but leave document order, tab order, focus on load and what Enter submits where they were. How: * Negative weights on the member fields. Core weights none of its own boxes below zero, so weights settle document and tab order at once. MobileFrontend's watermark, which led the mobile form at weight zero, is re-weighted to stay above the member section. * `autofocus` on the address box. Core adds its own to the username or password box after every handler has run, where nothing can unset it; the first in document order wins. * A nameless submit button, first in the form and clipped out of sight, is what Enter submits through. Named after neither route, it leaves the choice to the filled box, as #39 made possible. Core reads nothing from its own button's name. * The divider is described only where core described a password box, so a single-sign-on-only wiki gets no divider rather than a wrong one. Verified in Chromium on Vector and Minerva: focus lands in the address box on load, also with core's autofocus on the password box; Enter in the address box reaches the code screen posting no button name; Enter in the password box logs in; the hidden field leaves no gap and takes no pointer hits. Considered, omitted: * Hiding the password form: an opt-in setting of its own. * A plain "or" divider for wikis without a password form. * Demoting single sign-on buttons: which route a wiki with several recommends is not this extension's call. * `formnovalidate` on the hidden button: it would loosen the address box's own validation, which core's button did not have either. * Any JavaScript. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
feature/code-login-primary
branch
from
September 3, 2026 23:33
af364a5 to
79a59f2
Compare
JeroenDeDauw
marked this pull request as ready for review
September 3, 2026 23:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login form now leads with the member route on wikis that offer the code route. The address box
and "Continue with email" come first, that button is the form's primary one, focus lands in the
address box, and the password form follows under a divider reading "or log in with a password" in
place of "or". Enter submits whatever was filled in: an address asks for a code, a password logs
in. The account creation form and the code entry screen are untouched.
Done in the form description rather than site CSS, which would move the boxes but leave document
order, tab order, focus on load and what Enter submits where they were.
How:
settle document and tab order at once. MobileFrontend's watermark, which led the mobile form at
weight zero, is re-weighted to stay above the member section.
autofocuson the address box. Core adds its own to the username or password box after everyhandler has run, where nothing can unset it; the first in document order wins.
through. Named after neither route, it leaves the choice to the filled box, as
Ask for a code when Enter is pressed in the address box #39 made possible. Core reads nothing from
its own button's name.
gets no divider rather than a wrong one.
Verified in Chromium on Vector and Minerva: focus lands in the address box on load, also with core's
autofocus on the password box; Enter in the address box reaches the code screen posting no button
name; Enter in the password box logs in; the hidden field leaves no gap and takes no pointer hits.
Considered, omitted:
extension's call.
formnovalidateon the hidden button: it would loosen the address box's own validation, whichcore's button did not have either.