-
Notifications
You must be signed in to change notification settings - Fork 5
Create a page and its Main Subject in one step #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
be4a3f0
Add Special:CreateSubject
malberts f1dd542
Offer page-first Subject creation from the sidebar
malberts df2ca8f
Let the Subject creator open on a given Schema
malberts c15612b
Share the move dialog's page creation
malberts bcca23a
Let the Subject creator choose or create the page
malberts ef1550c
Mount the page-first creator on Special:CreateSubject
malberts 7da7a23
Offer page-first creation from the Schema page
malberts 0a7f754
Describe Schema-first creation in the guide
malberts c5bdb5c
Name the Schema pinned by Special:CreateSubject in its text form
malberts 6ce352d
Hold the page-first save to the page that was chosen
malberts f75d74e
Decide the Subject's tier when the page-first save starts
malberts 7bb91ab
Cover the page-first guards the mutation pass found untested
malberts a070145
Use one verb for every Subject creation entry
malberts ffea386
Move the Schema page's create button below its description
malberts 665df14
Name the Schema in the create link on its own page
malberts 95a51c1
Drop the Schema-specific sidebar link
malberts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
resources/ext.neowiki/src/components/CreateSubjectPage/CreateSubjectPage.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <template> | ||
| <div class="ext-neowiki-create-subject-page"> | ||
| <CdxButton | ||
| action="progressive" | ||
| weight="primary" | ||
| @click="subjectStore.openSubjectCreator()" | ||
| > | ||
| <CdxIcon :icon="cdxIconAdd" /> | ||
| {{ $i18n( 'neowiki-createsubject-button' ).text() }} | ||
| </CdxButton> | ||
|
|
||
| <SubjectCreatorDialog | ||
| :page-has-main-subject="false" | ||
| :choose-page="true" | ||
| :initial-schema-name="props.schemaName" | ||
| /> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { onMounted } from 'vue'; | ||
| import { CdxButton, CdxIcon } from '@wikimedia/codex'; | ||
| import { cdxIconAdd } from '@wikimedia/codex-icons'; | ||
| import SubjectCreatorDialog from '@/components/SubjectCreator/SubjectCreatorDialog.vue'; | ||
| import { useSubjectStore } from '@/stores/SubjectStore.ts'; | ||
|
|
||
| const props = defineProps<{ | ||
| schemaName?: string; | ||
| }>(); | ||
|
|
||
| const subjectStore = useSubjectStore(); | ||
|
|
||
| onMounted( () => { | ||
| subjectStore.openSubjectCreator(); | ||
| } ); | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding NewSubject as alias seems useful. Can see people coming from Wikibase typing that