Skip to content

enh(engines/utils): use tuple/dict comprehensions in PrepareBatchExtraInput #8831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Zeesejo wants to merge 8 commits into
base: dev
Choose a base branch
from
+7 −7
Draft

enh(engines/utils): use tuple/dict comprehensions in PrepareBatchExtraInput #8831

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0efb62
Fix: swap input_amplitude and target_amplitude in JukeboxLoss.forward
Zeesejo Apr 11, 2026
4417d79
Fix: remove redundant `1-` from SSIMLoss docstring examples
Zeesejo Apr 11, 2026
3777601
Merge branch 'dev' into dev
ericspod Apr 14, 2026
7afe692
Merge branch 'dev' into dev
ericspod Apr 15, 2026
ea4b1c3
Merge branch 'Project-MONAI:dev' into dev
Zeesejo Apr 17, 2026
4d4c7f6
enh(engines/utils): use tuple/dict comprehensions in PrepareBatchExtr…
Zeesejo Apr 17, 2026
85a1039
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 17, 2026
e0a012c
Fix: correct indentation of return statement in PrepareBatchExtraInpu…
Zeesejo Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions monai/engines/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ def __call__(
`kwargs` supports other args for `Tensor.to()` API.
"""
image, label = default_prepare_batch(batchdata, device, non_blocking, **kwargs)
args_ = []
kwargs_ = {}
args_: tuple = ()
kwargs_: dict = {}

def _get_data(key: str) -> torch.Tensor:
data = batchdata[key]
Expand All @@ -231,13 +231,13 @@ def _get_data(key: str) -> torch.Tensor:
return data

if isinstance(self.extra_keys, (str, list, tuple)):
for k in ensure_tuple(self.extra_keys):
args_.append(_get_data(k))
args_ = tuple(_get_data(k) for k in ensure_tuple(self.extra_keys))

elif isinstance(self.extra_keys, dict):
for k, v in self.extra_keys.items():
kwargs_.update({k: _get_data(v)})
kwargs_ = {k: _get_data(v) for k, v in self.extra_keys.items()}


return cast(torch.Tensor, image), cast(torch.Tensor, label), tuple(args_), kwargs_
return cast(torch.Tensor, image), cast(torch.Tensor, label), args_, kwargs_
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Broken indentation — file fails to import.

Lines 237 and 240 are over-indented, triggering IndentationError: unindent does not match any outer indentation level (confirmed by Ruff and the premerge/premerge-min pipelines). Beyond the syntax error, the return at line 240 sits at the elif block's indentation, so once parsed it would only execute when extra_keys is a dict — the str/list/tuple branch would fall through with no return.

🔧 Proposed fix 
         if isinstance(self.extra_keys, (str, list, tuple)):
             args_ = tuple(_get_data(k) for k in ensure_tuple(self.extra_keys))
-
         elif isinstance(self.extra_keys, dict):
-                        kwargs_ = {k: _get_data(v) for k, v in self.extra_keys.items()}
-
+            kwargs_ = {k: _get_data(v) for k, v in self.extra_keys.items()}

-                return cast(torch.Tensor, image), cast(torch.Tensor, label), args_, kwargs_
+        return cast(torch.Tensor, image), cast(torch.Tensor, label), args_, kwargs_
🧰 Tools
🪛 GitHub Actions: premerge

[error] 240-240: Python import failed with IndentationError: 'unindent does not match any outer indentation level' at line 240.

🪛 GitHub Actions: premerge-min

[error] 240-240: Python failed with IndentationError: "unindent does not match any outer indentation level" during import. Step: "python -c "import monai; monai.config.print_config()"".

🪛 Ruff (0.15.10)

[warning] 240-240: unindent does not match any outer indentation level

(invalid-syntax)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@monai/engines/utils.py` around lines 236 - 240, The indentation around the
branch that handles self.extra_keys is wrong: fix the over-indented lines so the
elif isinstance(self.extra_keys, dict): and its kwargs_ = {k: _get_data(v) ...}
are aligned with the other conditional branches and move the return statement
(return cast(torch.Tensor, image), cast(torch.Tensor, label), args_, kwargs_)
out of the elif-block to the outer scope of the function so it always executes;
ensure symbols referenced include self.extra_keys, _get_data, kwargs_, args_,
image and label so the dict, list/str/tuple and default branches all return
consistently.



class DiffusionPrepareBatch(PrepareBatch):
Expand Down
Loading