Skip to content

Remove Fuzzy Gdown Argument#784

Merged
ericspod merged 2 commits into
Project-MONAI:devfrom
ericspod:gdown_fuzzy_fix
Jul 8, 2026
Merged

Remove Fuzzy Gdown Argument#784
ericspod merged 2 commits into
Project-MONAI:devfrom
ericspod:gdown_fuzzy_fix

Conversation

@ericspod

@ericspod ericspod commented Jul 7, 2026

Copy link
Copy Markdown
Member

Description

This removes the now deprecated gdown "fuzzy" argument. This has found to be a breaking issue for running the CI for new bundles.

Status

Ready

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted large-file download handling to use the provided file details as-is, improving consistency when fetching files.
    • Streamlined download processing with no visible change to the user experience.

ericspod added 2 commits July 6, 2026 22:22
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod ericspod requested a review from garciadias July 7, 2026 02:24
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1ed4432-c2c7-4dba-a4ea-745ead7f9817

📥 Commits

Reviewing files that changed from the base of the PR and between d382e59 and 3c95a43.

📒 Files selected for processing (3)
  • ci/utils.py
  • ci/utils_deparate.py
  • ci/utils_deparate_ngc.py
💤 Files with no reviewable changes (3)
  • ci/utils_deparate.py
  • ci/utils_deparate_ngc.py
  • ci/utils.py

Walkthrough

Three CI utility scripts (ci/utils.py, ci/utils_deparate.py, ci/utils_deparate_ngc.py) had the line that forced lf_data["fuzzy"] = True removed from within their respective download_large_files() loops. Subsequent handling of hash fields, filepath construction, and the download_url call remain unchanged.

Changes

Remove forced fuzzy flag in download_large_files

Layer / File(s) Summary
Remove fuzzy=True override
ci/utils.py, ci/utils_deparate.py, ci/utils_deparate_ngc.py
The assignment forcing lf_data["fuzzy"] to True is removed from each download_large_files loop; remaining hash cleanup, filepath construction, and download_url calls are unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the gdown fuzzy argument.
Description check ✅ Passed The description matches the template with Description, Status, and checklist sections filled in sufficiently.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@garciadias garciadias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@ericspod ericspod merged commit b9e4d04 into Project-MONAI:dev Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants