Skip to content

fix: implement comparison operator for vector view #7538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DennisOSRM merged 2 commits into from
May 7, 2026
+3 −8
Merged

fix: implement comparison operator for vector view #7538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6f09c
fix: implement comparison operator for vector view
DennisOSRM May 7, 2026
497e6c7
fix: spaceship operator return type
DennisOSRM May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions include/util/vector_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <cstddef>

#include <algorithm>
#include <compare>
#include <iterator>
#include <type_traits>
#include <utility>
Expand Down Expand Up @@ -94,14 +95,8 @@ template <typename DataT> class VectorViewIterator
return it;
}

friend bool operator==(const VectorViewIterator &a, const VectorViewIterator &b)
{
return a.m_value == b.m_value;
}
friend bool operator!=(const VectorViewIterator &a, const VectorViewIterator &b)
{
return !(a == b);
}
friend bool operator==(const VectorViewIterator &a, const VectorViewIterator &b) = default;
friend bool operator<=>(const VectorViewIterator &a, const VectorViewIterator &b) = default;
Comment thread
DennisOSRM marked this conversation as resolved.
Outdated

private:
DataT *m_value;
Expand Down
Loading