fix(api)!: prevent OSM node ID truncation in match/route annotations

[DennisOSRM]

• fix(api)!: prevent OSM node ID truncation in match/route annotations
• Fix formatting: align inline comments in packed_vector test
• Mark incompatible fingerprint and update HTTP docs for 64-bit OSM node ids
• Add FlatBuffers Annotation.nodes roundtrip unit test
• Fix compile: avoid chained conversions in packed_vector test
• Fix compile: use OSMNodeID when extracting from PackedOSMIDs

[Copilot]

Pull request overview

Fixes OSM node ID truncation in the route/match annotations API: OSM node IDs above 2^34 were being silently masked by the PackedOSMIDs storage (34-bit) and again truncated by the FlatBuffers Annotation.nodes field (32-bit). Widens packed storage to 40 bits with an explicit overflow check, switches the FlatBuffers field to ulong (64-bit), bumps the data fingerprint, updates docs, and adds regression tests.

Changes:

• Widen PackedOSMIDs to 40 bits, add MAX_PACKED_OSM_NODE_ID and checkPackedOSMNodeIdFits guard called at every push site in extractor.cpp / files.hpp.
• Change FlatBuffers Annotation.nodes from [uint] to [ulong], update C++ route API serializer and JS bindings (BigUint64Array/BigInt), and bump fingerprint magic to invalidate caches built with the old 34-bit layout.
• Add regression unit tests (packed_vector.cpp round-trip + overflow throw, new library/fb_annotation_nodes.cpp for the 64-bit FB wire format) and document the breaking change in docs/http.md.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
include/extractor/packed_osm_ids.hpp	Switches packed width to 40 bits; adds MAX_PACKED_OSM_NODE_ID and checkPackedOSMNodeIdFits guard.
src/extractor/extractor.cpp	Calls the new overflow guard before pushing node_id into packed storage.
include/extractor/files.hpp	Adds the same guard in the raw-NB-graph reader and pulls in packed_osm_ids.hpp.
include/engine/api/flatbuffers/route.fbs	Promotes Annotation.nodes to [ulong].
include/engine/api/route_api.hpp	FlatBuffers nodes vector typed as uint64_t.
features/support/fbresult_generated.js	Regenerated JS bindings: BigInt/BigUint64Array/addInt64/8-byte vector stride.
src/util/fingerprint.cpp	Bumps magic number from OSRN to OSRO to invalidate old caches.
docs/http.md	Documents 64-bit node IDs and BigInt behavior for the FlatBuffers wire format.
unit_tests/util/packed_vector.cpp	Adds round-trip and overflow-guard regression tests for PackedOSMIDs.
unit_tests/library/fb_annotation_nodes.cpp	New test that round-trips 64-bit node IDs through the FlatBuffers Annotation.nodes field.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.