Add "minecraft.spectatetp". by Mickey42302 · Pull Request #1729 · PurpurMC/Purpur

Mickey42302 · 2025-11-24T04:20:02Z

I would like to suggest the addition of a "minecraft.spectatetp" permission node. It would allow for control over whether or not people can teleport to others in Spectator mode.

This idea originates from BasicLandMC: https://github.com/Basic-Land/BasicLandMC/blob/6936acca0bd195f762e9c09e8899d382eacd0c12/basiclandmc-server/minecraft-patches/sources/net/minecraft/server/network/ServerGamePacketListenerImpl.java.patch

LuanBertozzi7

good code🚀

katekerllenevich · 2026-02-21T04:12:27Z

Please add a configuration option that would enable the requirement of this permission. We avoid making any changes that would automatically change any behavior from Paper.

Mickey42302 · 2026-02-22T02:12:31Z

I'll update the code. Does "spectator-teleport-permission" sound like an appropriate name for the configuration setting?

ghost · 2026-02-22T02:26:30Z

"require-spectator-teleport-permission" sounds better to understand in my opinion

katekerllenevich · 2026-02-22T20:45:08Z

"require-spectator-teleport-permission" sounds better to understand in my opinion

This is what I would go with as well.

Mickey42302 · 2026-05-02T01:00:02Z

I've added a configuration entry for the permission node. It is set to "false" by default.

Are any other changes needed? I apologise for the delay as well. I have a lot going on in real life.

Mickey42302 · 2026-07-01T15:57:09Z

I'm going to update the patches to make them work with Java Edition 26.2. This might take a bit.

…leport-node.patch

…n-entry-for-spectatetp-permission.patch

…ectatetp-setting.patch

granny

Not a bad idea, just some requested changes.

If you register the permission in the PurpurPermissions class in the registerPermissions() method as default true, you can avoid needing to specify a config option for this permission.

Please include a PR to PurpurDocs in the permissions page, and for the config option if we decide to keep it.

granny · 2026-07-19T21:24:20Z

+-        if (this.player.isSpectator()) {
+-            for (ServerLevel level : this.server.getAllLevels()) {
+-                Entity entity = packet.getEntity(level);
+-                if (entity != null) {
+-                    this.player.teleportTo(level, entity.getX(), entity.getY(), entity.getZ(), Set.of(), entity.getYRot(), entity.getXRot(), true, org.bukkit.event.player.PlayerTeleportEvent.TeleportCause.SPECTATE); // CraftBukkit
+-                    return;
+        if (org.purpurmc.purpur.PurpurConfig.requireSpectatorTeleportPermission) {
+            if (this.player.isSpectator() && this.player.getBukkitEntity().hasPermission("minecraft.spectatetp")) {
+                for (ServerLevel level : this.server.getAllLevels()) {
+                    Entity entity = packet.getEntity(level);
+                    if (entity != null) {
+                        this.player.teleportTo(level, entity.getX(), entity.getY(), entity.getZ(), Set.of(), entity.getYRot(), entity.getXRot(), true, org.bukkit.event.player.PlayerTeleportEvent.TeleportCause.SPECTATE); // CraftBukkit
+                        return;
+                    }
+                }
+            }
+        } else {
+            if (this.player.isSpectator()) {
+                for (ServerLevel level : this.server.getAllLevels()) {
+                    Entity entity = packet.getEntity(level);
+                    if (entity != null) {
+                        this.player.teleportTo(level, entity.getX(), entity.getY(), entity.getZ(), Set.of(), entity.getYRot(), entity.getXRot(), true, org.bukkit.event.player.PlayerTeleportEvent.TeleportCause.SPECTATE); // CraftBukkit
+                        return;
+                    }


This is a pretty noisy diff for what it adds. Please reduce it to a maintainable level.

granny · 2026-07-19T21:36:25Z

+-                    this.player.teleportTo(level, entity.getX(), entity.getY(), entity.getZ(), Set.of(), entity.getYRot(), entity.getXRot(), true, org.bukkit.event.player.PlayerTeleportEvent.TeleportCause.SPECTATE); // CraftBukkit
+-                    return;
+        if (org.purpurmc.purpur.PurpurConfig.requireSpectatorTeleportPermission) {
+            if (this.player.isSpectator() && this.player.getBukkitEntity().hasPermission("minecraft.spectatetp")) {


I don't like the permission name and i'm not sure about putting it under the "minecraft" perm root. Maybe purpur.spectator-can-teleport-to-players? Open to suggestions other than minecraft.spectatetp.

granny · 2026-07-19T21:41:14Z

+             org.purpurmc.purpur.PurpurConfig.clampEnchantLevels = purpurConfiguration.getBoolean("settings.enchantment.clamp-levels", true);
+             org.purpurmc.purpur.PurpurConfig.registerMinecraftDebugCommands = purpurConfiguration.getBoolean("settings.register-minecraft-debug-commands"); // Purpur - register minecraft debug commands
+             org.purpurmc.purpur.PurpurConfig.registerMinecraftDisabledCommands = purpurConfiguration.getBoolean("settings.register-minecraft-disabled-commands"); // Purpur - register disabled minecraft commands
+            org.purpurmc.purpur.PurpurConfig.requireSpectatorTeleportPermission = purpurConfiguration.getBoolean("settings.require-spectator-teleport-permission"); // Purpur - require spectator teleport permission


settings.require-permission-spectator-teleport-to-players? 🤷

…ermission.patch

Mickey42302 · 2026-07-20T18:19:40Z

I updated the code. Before I submit a pull request to the PurpurDocs repository, I'd like to ask if this is what you're looking for?

djohts · 2026-07-20T18:35:48Z

I updated the code. Before I submit a pull request to the PurpurDocs repository, I'd like to ask if this is what you're looking for?

pretty sure granny meant to modify the existing patch instead of adding another one on top of it that "makes code less noisy"

kacimiamine · 2026-07-20T18:37:56Z

Yeah those patches are really wrong. You should update the current patch you did, the 0022- patch and make it less noisy (simpler and shorter)

Mickey42302 · 2026-07-20T19:57:51Z

Is this better?

kacimiamine · 2026-07-20T20:32:21Z

+            // Purpur end - Add settings for enabling commands that are unavailable by default.
+
+            // Purpur start - Add setting which can be used to enable a permission node that controls the ability for spectators to teleport to other players.
+            org.purpurmc.purpur.PurpurConfig.requirePermissionSpectatorTeleportToPlayers = purpurConfiguration.getBoolean("settings.require-permission-spectator-teleport-to-players"); // Purpur - require permission spectator teleport to players


You should comment here with // Purpur instead of having // Purpur start and // Purpur end

kacimiamine · 2026-07-20T20:33:27Z

+-                if (entity != null) {
+-                    this.player.teleportTo(level, entity.getX(), entity.getY(), entity.getZ(), Set.of(), entity.getYRot(), entity.getXRot(), true, org.bukkit.event.player.PlayerTeleportEvent.TeleportCause.SPECTATE); // CraftBukkit
+-                    return;
+            if (!org.purpurmc.purpur.PurpurConfig.requirePermissionSpectatorTeleportToPlayers || this.player.getBukkitEntity().hasPermission("purpur.spectator-can-teleport-to-players")) {


Add a // Purpur comment

Mickey42302 · 2026-07-21T01:38:29Z

The comments are updated now.

Add files via upload

252fe38

This comment was marked as spam.

Sign in to view

LuanBertozzi7 reviewed Feb 7, 2026

View reviewed changes

katekerllenevich requested a review from LuanBertozzi7 February 21, 2026 04:12

Add files via upload

3954084

Mickey42302 added 3 commits May 1, 2026 21:24

Add to PurpurConfig

e26f4dc

Add files via upload

2436898

Merge branch 'PurpurMC:ver/26.2' into spectatetp

27800a9

Mickey42302 added 4 commits July 1, 2026 11:58

Delete purpur-server/minecraft-patches/features/0021-Add-spectator-te…

0f9cfc3

…leport-node.patch

Delete purpur-server/minecraft-patches/features/0022-Add-configuratio…

7e24aa8

…n-entry-for-spectatetp-permission.patch

Delete purpur-server/minecraft-patches/features/0023-Add-check-for-sp…

d552351

…ectatetp-setting.patch

Add files via upload

d5052dc

Mickey42302 changed the base branch from ver/1.21.10 to ver/26.2 July 1, 2026 16:11

Mickey42302 added 2 commits July 1, 2026 12:32

Add requireSpectatorTeleportPermission setting

07a9f6a

Add files via upload

d94d0a1

granny requested changes Jul 19, 2026

View reviewed changes

Mickey42302 added 4 commits July 20, 2026 14:10

Merge branch 'PurpurMC:ver/26.2' into spectatetp

1a00bef

Update PurpurPermissions.java

8d38b72

Add files via upload

cd88d62

Delete purpur-server/minecraft-patches/features/0022-Add-spectatetp-p…

d32ef39

…ermission.patch

Rewriting the original patch file

82b2fe2

Mickey42302 added 5 commits July 20, 2026 14:48

Rewriting the original patch file

fb109cf

Update PurpurConfig.java

70963be

Fix configuration key for spectator teleport permission

922e689

Update PurpurConfig.java

01d8d11

Add files via upload

159f2e8

kacimiamine reviewed Jul 20, 2026

View reviewed changes

Add files via upload

5e4d1b3

Uh oh!

Uh oh!

Conversation

Mickey42302 commented Nov 24, 2025

Uh oh!

This comment was marked as spam.

LuanBertozzi7 left a comment

Choose a reason for hiding this comment

Uh oh!

katekerllenevich commented Feb 21, 2026

Uh oh!

Mickey42302 commented Feb 22, 2026

Uh oh!

ghost commented Feb 22, 2026 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katekerllenevich commented Feb 22, 2026

Uh oh!

Mickey42302 commented May 2, 2026

Uh oh!

Mickey42302 commented Jul 1, 2026

Uh oh!

granny left a comment

Choose a reason for hiding this comment

Uh oh!

granny Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

granny Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

granny Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Jul 20, 2026

Uh oh!

djohts commented Jul 20, 2026

Uh oh!

kacimiamine commented Jul 20, 2026

Uh oh!

Mickey42302 commented Jul 20, 2026

Uh oh!

kacimiamine Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

kacimiamine Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ghost commented Feb 22, 2026 •

edited by ghost

Loading