Add leaves instant decay option#1803
Merged
Merged
Conversation
This is better so that we ared not firing randomTick twice as this may cause issues with plugins that listen to the event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option to instant decay the leaves after breaking a tree.
Note that even if
randomTick()gets called every tick intick(), it doesn't have any performance issues even if it runs on ALL leaves, since for leaves not decaying, it's just a boolean check and return.I tested this and I didn't see any issues. This would be a nice addition since doing it with a plugin requires a bit more logic and might not be as intended.
How this works:
https://discord.com/channels/685683385313919172/720374890472931328/1525151676447723523
Update: thanks to Billy's suggestion, we made a new method instead of randomTick, so depending on the config, only one of them will fire (either decay on randomTick, or decay on tick if config is enabled)