Fix # isort: off not preserving preceding import section#2552
Closed
skshmjn wants to merge 1 commit into
Closed
Conversation
When # isort: off triggered flushing the accumulated import section, the code always sorted/reformatted it before writing. Now it writes raw_import_section instead, preserving the original ordering, formatting, and duplicates. Fixes PyCQA#2528
Member
|
Fixed in #2553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When # isort: off appears after an import section, isort was still sorting/reformatting/deduplicating the imports before the directive — affecting both import and from ... import statements.
Fix: In core.py, when stripped_line == "# isort: off" triggers the import section flush, write raw_import_section (the original unmodified text) instead of the sorted output.
Test: Updated the existing test_isort_off_and_on assertion to reflect corrected behavior (duplicates before # isort: off are now preserved).
Fixes #2528