This repository was archived by the owner on Jan 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Python3 support #200
Open
jneves
wants to merge
11
commits into
PyconUK:master
Choose a base branch
from
jneves:python3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python3 support #200
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
65aab84
setup testing for multiple python versions
jneves 6d21d11
add python3 version of vobject to requirements
jneves bbb71fd
add python3 version of wok to requirements
jneves dc6c3dc
update wok version
jneves fce8765
update py3 wok version
jneves 62e0a93
updated wok requirement
jneves 65bb0a7
fixed hooks
jneves 1b6b741
clean debug
jneves 5845de4
added new hooks setup
jneves 474f69f
removed useless changes
jneves 04d1e9d
work-around for lxml string/byte string behaviour
jneves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,7 @@ | ||
| ''' __hooks__.py | ||
| from flat_schedule import create_flat_schedule | ||
| from guidebook import create_csv_schedule | ||
| from schedule_summary import create_summary_schedule | ||
|
|
||
| Attach Python functions to wok hooks. | ||
| ''' | ||
|
|
||
| import flat_schedule | ||
| import guidebook | ||
| import schedule_summary | ||
|
|
||
| # The `hooks` dictionary that wok will import | ||
| # See http://wok.mythmon.com/docs/hooks/ | ||
| hooks = { | ||
| 'site.done': [ | ||
| flat_schedule.create_flat_schedule, | ||
| guidebook.create_csv_schedule, | ||
| schedule_summary.create_summary_schedule, | ||
| ], | ||
| } | ||
| 'site.done': [create_flat_schedule, create_csv_schedule, create_summary_schedule], | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a cosmetic change -- am I correct? Unless there's a good reason to, I think it's worth avoiding making cosmetic changes in an unrelated pull request.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have no idea what the hell went on here. I must have deleted the file by mistake somehow because it wasn't on my repo, I'll reset it. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,11 @@ | ||
| awesome-slugify==1.4 | ||
| docutils==0.8.1 | ||
| Jinja2==2.7.3 | ||
| LinkChecker==9.3 | ||
| #LinkChecker==9.3 # waiting for py3 version | ||
| lxml==3.4.4 | ||
| Markdown==2.1.1 | ||
| MarkupSafe==0.23 | ||
| py==1.4.27 | ||
| Pygments==1.4 | ||
| pytest==2.5.2 | ||
| python-dateutil==2.4.2 | ||
| pytz==2015.4 | ||
| PyYAML==3.10 | ||
| regex==2015.5.10 | ||
| requests==2.7.0 | ||
| six==1.9.0 | ||
| Unidecode==0.4.17 | ||
| vobject==0.6.6 | ||
| wok==1.1.1 | ||
| -e git+https://github.com/tBaxter/vobject.git@5bdf21751a6f443045e05db862e00be5bbd006f3#egg=vobject | ||
| -e git+https://github.com/jneves/wok.git@21ce6ea44483218b2380104b6ada8865122ddf2c#egg=wok |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have these been added here? Does wok now not invoke the hooks?
The problem with this is that these hooks get run before the site gets built. Some of the hooks depend on the built HTML, so either they will work with old HTML, or will fail because there is not old HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be removed. I did that while trying to workaround the hooks not running. Fixing it.