Add support for Q10 diagnostics data - #909
Open
allenporter wants to merge 1 commit into
Open
Conversation
allenporter
marked this pull request as draft
July 31, 2026 15:02
allenporter
changed the title
allenporter
force-pushed
the
fix-q10-diagnostics-display
branch
from
July 31, 2026 15:06
026b165 to
87d9c21
Compare
allenporter
force-pushed
the
fix-q10-diagnostics-display
branch
from
July 31, 2026 15:13
87d9c21 to
c9349b2
Compare
allenporter
marked this pull request as ready for review
July 31, 2026 15:39
Lash-L
requested changes
Aug 11, 2026
|
|
||
| def as_dict(self, exclude: set[str] | None = None) -> dict[str, Any]: | ||
| """Return the trait data as a dictionary, excluding large binary data.""" | ||
| import dataclasses |
Collaborator
There was a problem hiding this comment.
Should probably just be top of the file right?
Comment on lines
+169
to
+170
| if isinstance(value, RoborockBase): | ||
| result[name] = value.as_dict() |
Collaborator
There was a problem hiding this comment.
This is going to grab all of the traits right? This will duplicate map I think? As MapDpsTrait(MapDps, UpdatableTrait) -> MapDps(RoborockBase)
Any of these traits have info we don't want in diagnostics? Not as familiar with them but there might be ssid. I don't recall if diagnostics auto filters out a lot of this
Collaborator
|
Previously missed this one - sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes state-holding properties for Q10 devices in
diagnostic_data(). Maps are included but large binary fields (image_content,map_data) are filtered out.