Skip to content

docs:Fixes #5257 - #5297

Merged
abbycross merged 3 commits into
Qiskit:max-execution-time-checksfrom
JJRBEST:5257
Jul 28, 2026
Merged

docs:Fixes #5257#5297
abbycross merged 3 commits into
Qiskit:max-execution-time-checksfrom
JJRBEST:5257

Conversation

@JJRBEST

@JJRBEST JJRBEST commented Jun 24, 2026

Copy link
Copy Markdown

This PR fixes the issue described in Closes #5257

@JJRBEST
JJRBEST requested a review from a team June 24, 2026 06:33
@qiskit-bot

Copy link
Copy Markdown
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant

CLAassistant commented Jun 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@abbycross
abbycross requested a review from jyu00 June 24, 2026 17:17
Comment thread docs/guides/max-execution-time.ipynb Outdated
Comment thread docs/guides/max-execution-time.ipynb Outdated
Comment thread docs/guides/max-execution-time.ipynb Outdated
Comment thread docs/guides/max-execution-time.ipynb Outdated
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@JJRBEST

JJRBEST commented Jun 26, 2026

Copy link
Copy Markdown
Author

I have verified the notebook docs/guides/max-execution-time.ipynb locally using tox and it passes all checks.

The CI currently fails with an AccountNotFoundError due to the lack of IBM Quantum credentials in the forked environment, which is expected. I have attached the proof that the notebook executes correctly locally
Local_Test_OK

@JJRBEST

JJRBEST commented Jun 29, 2026

Copy link
Copy Markdown
Author

Hi, I have addressed the issue and verified the changes locally.
I have run ./fix and ./check in my local environment, and all checks passed successfully.
image

@JJRBEST

JJRBEST commented Jul 7, 2026

Copy link
Copy Markdown
Author

The notebook executed successfully against real hardware, and tox reported congratulations :). I also confirmed with git diff that the notebook content already matches the version currently in this PR, so no further changes were needed.
Let me know if there's anything else needed for review.
image

@beckykd beckykd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment thread docs/guides/max-execution-time.ipynb Outdated
Comment thread docs/guides/max-execution-time.ipynb Outdated
Comment thread docs/guides/max-execution-time.ipynb Outdated
@beckykd

beckykd commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

The notebook executed successfully against real hardware, and tox reported congratulations :).

Great! We can ignore the notebook execution error then.

Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@JJRBEST

JJRBEST commented Jul 9, 2026

Copy link
Copy Markdown
Author

I have added
ibm-cloud-token: ${{ secrets.IBM_CLOUD_TEST_TOKEN }}
instance: ${{ vars.IBM_CLOUD_TEST_CRN }}
to the GitHub repository for testing them, and I have also tested tox and tox -- docs/guides/max-execution-time.ipynb --write --test-strategy=hardware, both of which succeeded.
image
image
image

@beckykd

beckykd commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

I think this is ready to merge now; @jyu00 do you have further comments?

@beckykd
beckykd requested a review from jyu00 July 27, 2026 20:48

@jyu00 jyu00 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Although @beckykd don't forget to update this page for the Qiskit Runtime name change.

@beckykd
beckykd self-requested a review July 28, 2026 19:49

@beckykd beckykd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks! Using #5436 to run final checks and merge.

@beckykd
beckykd enabled auto-merge July 28, 2026 19:50
@beckykd
beckykd disabled auto-merge July 28, 2026 19:52
@abbycross
abbycross changed the base branch from main to max-execution-time-checks July 28, 2026 20:11
@abbycross
abbycross merged commit 70f99d2 into Qiskit:max-execution-time-checks Jul 28, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Clarify service-set max execution time

6 participants