Skip to content

fix: Use froundeven for lowering float roundings - #2293

Merged
maximilianruesch merged 1 commit into
release/1.0from
mr/cherry/froundeven
Sep 7, 2026
Merged

fix: Use froundeven for lowering float roundings#2293
maximilianruesch merged 1 commit into
release/1.0from
mr/cherry/froundeven

Conversation

@maximilianruesch

Copy link
Copy Markdown
Collaborator

(cherry picked from commit ed6be7b)

Backport of #2286

@maximilianruesch
maximilianruesch requested a review from a team as a code owner September 7, 2026 16:44
@maximilianruesch maximilianruesch added the C-backport A PR that backports a specific commit to a release branch. label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Projectguppylang
Branchmr/cherry/froundeven
TestbedLinux

🚨 4 Alerts

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compilehugr_bytes
bytes x 1e3
📈 plot
🚷 threshold
🚨 alert (🔔)
64.05 x 1e3
(+3.14%)Baseline: 62.10 x 1e3
62.72 x 1e3
(102.12%)

tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compilehugr_bytes
bytes x 1e3
📈 plot
🚷 threshold
🚨 alert (🔔)
29.06 x 1e3
(+4.53%)Baseline: 27.80 x 1e3
28.08 x 1e3
(103.49%)

tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compilehugr_bytes
bytes x 1e3
📈 plot
🚷 threshold
🚨 alert (🔔)
7.84 x 1e3
(+8.19%)Baseline: 7.24 x 1e3
7.32 x 1e3
(107.11%)

tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compilehugr_bytes
bytes x 1e3
📈 plot
🚷 threshold
🚨 alert (🔔)
10.77 x 1e3
(+9.26%)Baseline: 9.86 x 1e3
9.96 x 1e3
(108.18%)

Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes
(Result Δ%)
Upper Boundary
nodes
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
64.05 x 1e3
(+3.14%)Baseline: 62.10 x 1e3
62.72 x 1e3
(102.12%)

📈 view plot
🚷 view threshold
4,585.00
(0.00%)Baseline: 4,585.00
4,630.85
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
29.06 x 1e3
(+4.53%)Baseline: 27.80 x 1e3
28.08 x 1e3
(103.49%)

📈 view plot
🚷 view threshold
1,301.00
(0.00%)Baseline: 1,301.00
1,314.01
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
7.84 x 1e3
(+8.19%)Baseline: 7.24 x 1e3
7.32 x 1e3
(107.11%)

📈 view plot
🚷 view threshold
310.00
(0.00%)Baseline: 310.00
313.10
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
10.77 x 1e3
(+9.26%)Baseline: 9.86 x 1e3
9.96 x 1e3
(108.18%)

📈 view plot
🚷 view threshold
411.00
(0.00%)Baseline: 411.00
415.11
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/1.0@0345e72). Learn more about missing BASE report.

Files with missing lines Patch % Lines
guppylang/src/guppylang/std/num.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release/1.0    #2293   +/-   ##
==============================================
  Coverage               ?   93.14%           
==============================================
  Files                  ?      152           
  Lines                  ?    14781           
  Branches               ?        0           
==============================================
  Hits                   ?    13768           
  Misses                 ?     1013           
  Partials               ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maximilianruesch maximilianruesch changed the title fix: Use froundeven for lowering float roundings (#2286) fix: Use froundeven for lowering float roundings Sep 7, 2026
@maximilianruesch
maximilianruesch merged commit 1da77fa into release/1.0 Sep 7, 2026
13 of 14 checks passed
@maximilianruesch
maximilianruesch deleted the mr/cherry/froundeven branch September 7, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-backport A PR that backports a specific commit to a release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants