Pin the dependencies in requirements.txt to the exact package versions currently used by: mainnet1.7.0-beta - #994
Open
ping-ke wants to merge 1 commit into
Open
Pin the dependencies in requirements.txt to the exact package versions currently used by: mainnet1.7.0-beta#994ping-ke wants to merge 1 commit into
requirements.txt to the exact package versions currently used by: mainnet1.7.0-beta#994ping-ke wants to merge 1 commit into
Conversation
requirements.txt to the exact package versions currently used by: quarkchaindocker/pyquarkchain:mainnet1.7.0-betarequirements.txt to the exact package versions currently used by: mainnet1.7.0-beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the dependencies in
requirements.txtto the exact package versions currently used by:quarkchaindocker/pyquarkchain:mainnet1.7.0-betaMotivation
The previous version ranges allowed dependency resolution to change over time, which could produce an environment different from the tested mainnet Docker image.
Using the package versions from
mainnet1.7.0-betaprovides:Changes
requirements.txtwith exact versions from the runningmainnet1.7.0-betacontainer.pyethashpinned to commit:907b7d8064d3be09536e754bbf469b442f2e213dVerification
The following verification has been completed:
quarkchaindocker/pyquarkchain:mainnet1.7.0-gammawith the updatedrequirements.txt.mainnet1.7.0-gammaimage and confirmed that it runs and synchronizes with the network.Reviewer Verification
Reviewers can independently verify the change with the following steps:
Start a container using
quarkchaindocker/pyquarkchain:mainnet1.7.0-beta, inspect its installed package versions, and confirm that the direct dependencies match the versions pinned inrequirements.txt.Start a node using
quarkchaindocker/pyquarkchain:mainnet1.7.0-gammaand confirm that it starts successfully, connects to peers, and continues synchronizing blocks without dependency or runtime errors.