Skip to content

ci: check all workspace targets before release builds - #624

Open
blacks1ne wants to merge 1 commit into
QuilibriumNetwork:v2.1.0.25from
blacks1ne:fix/ci-check-all-targets
Open

blacks1ne wants to merge 1 commit into
QuilibriumNetwork:v2.1.0.25from
blacks1ne:fix/ci-check-all-targets

Conversation

@blacks1ne

@blacks1ne blacks1ne commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Base: f5b671a6

The build job runs cargo check --workspace --locked, and the release-build
matrix is gated on it (needs: build) so three runners aren't spent on a
workspace that doesn't compile.

--workspace checks lib and bin targets only. It does not compile #[cfg(test)]
code, integration tests, benches or examples. A change that breaks a test target
therefore leaves build green, lets the release matrix start, and fails later in
test, where the cause reads as a test failure rather than a compile error.
#613 was exactly that.

--all-targets adds those targets to the same check, sharing the rust-cache
entry the job already restores. Measured on one host, --cpus 10 / CARGO_BUILD_JOBS=6, CARGO_INCREMENTAL=0, off a clean v2.1.0.25:

  • a PR-shaped run — touch crates/quil-engine/src/lib.rs, re-check — is
    20/21 s without, 24/24 s with: about +3.5 s
  • populating the extra targets after a cache miss costs +34 s once (44 s vs
    10 s) and +264 MB of cache (4.67 GB vs 4.40 GB)
  • alternating the two flag sets left the target directory byte-identical, so
    having both forms in play does not thrash the cache

--all-targets has compiled cleanly since #619.

Red checks here are the LFS budget, not this diff.

Validation: git diff --check; the workflow YAML parses.

@blacks1ne
blacks1ne force-pushed the fix/ci-check-all-targets branch 2 times, most recently from bd2d870 to da445fa Compare August 27, 2026 14:15
@blacks1ne
blacks1ne force-pushed the fix/ci-check-all-targets branch 2 times, most recently from 95c8ace to e9ad7eb Compare September 6, 2026 15:00
@blacks1ne
blacks1ne force-pushed the fix/ci-check-all-targets branch from e9ad7eb to b5295f7 Compare September 8, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant