Conversation
blacks1ne
force-pushed
the
fix/ci-check-all-targets
branch
2 times, most recently
from
August 27, 2026 14:15
bd2d870 to
da445fa
Compare
blacks1ne
force-pushed
the
fix/ci-check-all-targets
branch
2 times, most recently
from
September 6, 2026 15:00
95c8ace to
e9ad7eb
Compare
blacks1ne
force-pushed
the
fix/ci-check-all-targets
branch
from
September 8, 2026 07:11
e9ad7eb to
b5295f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
f5b671a6The
buildjob runscargo check --workspace --locked, and therelease-buildmatrix is gated on it (
needs: build) so three runners aren't spent on aworkspace that doesn't compile.
--workspacechecks lib and bin targets only. It does not compile#[cfg(test)]code, integration tests, benches or examples. A change that breaks a test target
therefore leaves
buildgreen, lets the release matrix start, and fails later intest, where the cause reads as a test failure rather than a compile error.#613 was exactly that.
--all-targetsadds those targets to the same check, sharing therust-cacheentry the job already restores. Measured on one host,
--cpus 10 / CARGO_BUILD_JOBS=6,CARGO_INCREMENTAL=0, off a cleanv2.1.0.25:crates/quil-engine/src/lib.rs, re-check — is20/21 s without, 24/24 s with: about +3.5 s
10 s) and +264 MB of cache (4.67 GB vs 4.40 GB)
having both forms in play does not thrash the cache
--all-targetshas compiled cleanly since #619.Red checks here are the LFS budget, not this diff.
Validation:
git diff --check; the workflow YAML parses.