[perf][rocm]: restore full Graph and cache strict Attention schedules - #393
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
maxiaosong1124
self-requested a review
September 8, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is the post-merge ROCm performance follow-up to #390, based on the VIME scheduling work merged by #377. It keeps the strict Qwen3 Dense arithmetic contract and changes only RL-Kernel runtime/adapter code.
Changes
FULL_AND_PIECEWISEGraph execution on ROCm by keeping strict IPC collective generations in device-visible state.The final diff against
testchanges two RL-Kernel files:rl_engine/integrations/vllm_runtime.pyrl_engine/kernels/ops/rocm/attention/strict_runtime.pyNo Megatron-LM, vLLM, or VIME source is modified. CUDA dispatch is unchanged.
Matched MI300X configuration
1ba8448FULL_AND_PIECEWISE, capture max 32, route-specific AOT cacheROCM_AITER_FA; direct paged CK; Split-KV disabledRound 1 includes process-local compile/warmup effects. Steady values below are the mean of rounds 2 and 3.
Performance
pr390-full-graph-route-cache-3round-p-p-v132pr390-position-plan-cache-3round-r-r-v135The remaining steady gap is training-side rather than rollout-side. Relative to the immediately preceding strict run, the position-plan cache reduces actor train from 1.964626 s to 1.878836 s (-4.37%) and train compute from 3.069056 s to 2.939528 s (-4.22%). End-to-end wait varied by about 0.24 s between runs, so the optimization claim is limited to the directly measured compute phases.
Exactness
torch.equalThe final R/R run completed all three steps with no validation errors and no arithmetic fallback.