SM8550: fix Pocket S Mini panel for Linux 7.2 - #3239
Merged
Conversation
The AYANEO Pocket S Mini landed on next while the 7.2 bump was still on its own branch, so it was never converted to the two APIs 7.2 changed. Both sides were green on their own; only the merge is broken. Build fix: drm_panel_init() is no longer exported in 7.2, so 0064 uses devm_drm_panel_alloc() like the other 13 panel drivers. Runtime fix: the sgm3804 node still used the pre-7.2 binding - one regulator with both GPIOs in reset-gpios. Upstream's driver registers two rails from pos/neg child nodes, each with its own enable-gpios, so the node is migrated the way the other six boards were and the panel gains the avee supply it was silently missing. Voltages are 5200000, matching the selector the old driver actually programmed. Verified: all 10 SM8550 panel patches apply with zero rejects on 7.2 and the Pocket S Mini dtb compiles with avdd/avee resolving to tlmm 152/153. NOT hardware validated - a wrong migration shows as a lit backlight over a black panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AYANEO Pocket S Mini landed on next while the 7.2 bump was still on its own branch, so it was never converted to the two APIs 7.2 changed. Both sides were green on their own; only the merge is broken.
Build fix: drm_panel_init() is no longer exported in 7.2, so 0064 uses devm_drm_panel_alloc() like the other 13 panel drivers.
Runtime fix: the sgm3804 node still used the pre-7.2 binding - one regulator with both GPIOs in reset-gpios. Upstream's driver registers two rails from pos/neg child nodes, each with its own enable-gpios, so the node is migrated the way the other six boards were and the panel gains the avee supply it was silently missing. Voltages are 5200000, matching the selector the old driver actually programmed.
Verified: all 10 SM8550 panel patches apply with zero rejects on 7.2 and the Pocket S Mini dtb compiles with avdd/avee resolving to tlmm 152/153. NOT hardware validated - a wrong migration shows as a lit backlight over a black panel.
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES