[release/2.12] - Update triton commit and update logic to build from branch instead of triton.txt#3266
Open
jataylo wants to merge 2 commits into
Open
[release/2.12] - Update triton commit and update logic to build from branch instead of triton.txt#3266jataylo wants to merge 2 commits into
jataylo wants to merge 2 commits into
Conversation
Update the Triton pin to the tip of ROCm release/internal/3.7.x and route non-XPU Triton builds through the ROCm fork. Co-authored-by: Cursor <cursoragent@cursor.com>
Use release/internal/3.7.x for non-XPU Triton source builds in Docker and wheel CI instead of checking out the triton.txt commit. Co-authored-by: Cursor <cursoragent@cursor.com>
jataylo
requested review from
jeffdaily,
jithunnair-amd and
pruthvistony
as code owners
|
Jenkins build for 123256577417ef6c232f5abb0cc534cd2dea21ab commit finished as FAILURE |
|
@jataylo can you trigger pytorch builds here https://github.com/ROCm/TheRock/actions/workflows/build_portable_linux_pytorch_wheels.yml and link them in the PR description? That would ensure that theRock doesn't get affected by this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update triton.txt for visibility but stop building from the txt file instead always use tip of branch