forked from OrMSC/SimOR
-
Notifications
You must be signed in to change notification settings - Fork 0
Estimation #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
americalexander
wants to merge
67
commits into
main
Choose a base branch
from
estimation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Estimation #17
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
ab7b0c7
adding estimation configs
dhensle 066a475
Merge branch 'initial_model_setup' into estimation
americalexander 75202ac
Fix school location model spec
americalexander 732eb96
adding missing occupation segment in wlc
dhensle 89f1223
adding missing occup to shadow pricing
dhensle 6f5f5bb
Merge remote-tracking branch 'origin/new_synthetic_pop' into estimation
americalexander becafb2
Remove hard-coded alt # from ext worker ident model
americalexander 2229159
Fix jtf composition spec
americalexander b62c9be
Fix dupl. label in nm tour destination spec
americalexander 74a57dd
updated nm size terms
americalexander 37e5185
Merge branch 'initial_model_setup' into estimation
americalexander 75492fd
ISO timestamp format
americalexander d23e483
more dest size terms updates
americalexander 5f1e2a5
update trace label for Ext NMT Ident
americalexander 2b2e4ce
Destination choice size terms made nonzero
americalexander be6c07e
Merge branch 'initial_model_setup' into estimation
dhensle 867f5ba
preprocessor adds TAZ column to landuse
dhensle d97f584
fixing logging file
dhensle 290af20
active acres size term
dhensle c5b94ec
Fix logging config
americalexander 59682f3
Fix typo in previous commit
americalexander 6a3ba21
clean up labels, knr skims for bnr, school trip size terms
dhensle 04cfdd3
Merge branch 'estimation' of https://github.com/RSGInc/SimOR into est…
dhensle 4aac9b3
One more logging fix
americalexander 18c6803
allowing FT workers to go to univ
dhensle cb38524
shopping to HCS employment
americalexander 04fb248
Actually lets just make it all employment
americalexander b7d73d0
estimation specific size terms
dhensle 80172a3
Merge branch 'estimation' of https://github.com/RSGInc/SimOR into est…
dhensle 327ebe5
adding missing alts for estimation
dhensle 2597171
turn availability conditions off for trip mode choice
dhensle e5d13e1
Add one weird NMT frequency alt
americalexander 0734d10
Update trip mode choice spec unavail conds for estimation
americalexander 668da65
Merge remote-tracking branch 'origin/initial_model_setup' into estima…
americalexander 2371298
Fix mismatched parens in annotate persons
americalexander 978f781
Ensure consistent number of fields
americalexander a8b8eaf
define KNR_available
americalexander 99e0234
Merge remote-tracking branch 'origin/maz_col_check' into estimation
americalexander f9115b4
Bugfix in pstudent annotation
americalexander cb43357
Trip mode choice bugfixes
americalexander 841334e
remove hard-coded external alternative
americalexander 63da533
Transit pass subsidy spec changes
americalexander 547655c
Compatibility fixes for previous commit
americalexander 2c57edc
Fix auto sufficiency condition
americalexander 615f553
Fix transit pass subsidy availability cond
americalexander 29354e4
Update escortee age limit
americalexander d581a66
Merge remote-tracking branch 'origin/main' into estimation
americalexander 6371c81
NMT scheduling fixes
americalexander 01511ec
Trip mode choice spec changes
americalexander 6bc3337
More trip mode choice spec changes
americalexander 991fc99
Updated destination size terms
americalexander 8b0bff5
Rebuild cropped dataset
americalexander 0d9814a
Rebuild SKATS cropped data
americalexander c5545f9
Remove stray commas from land use
americalexander 1bbadc5
Add launch configs
americalexander 01932e5
Merge remote-tracking branch 'origin/main' into estimation
americalexander 2ebbd39
rename external size term
americalexander 514677e
Merge branch 'main' into estimation
americalexander 2d26de6
Fixed SKATS land use
americalexander e2e8818
Merge remote-tracking branch 'origin/main' into estimation
americalexander f4df952
Fix size term formatting breaking CI test
americalexander 650b89f
Reset destination size terms for non-estimation
americalexander b098496
Pull preprocessor.py from main
americalexander fa4e846
Reset new coefficients to 0
americalexander b25391d
Revert preprocessor reversion
americalexander af2311f
Merge remote-tracking branch 'origin/main' into estimation
americalexander a50626f
Rogue nmtf alts
americalexander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| # columns from land_use table to add to df | ||
| land_use_columns: ['EMP_RET', 'EMP_TOTAL', 'TOTHHS', 'walk_dist_local_bus'] | ||
| explicit_chunk: 0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| Label,Description,Expression,work_external,work_internal | ||
| util_dist_to_nearest_ext_station,Distance to nearest external station,dist_to_external_zone,coef_dist_to_nearest_ext_station, | ||
| Label,Description,Expression,work_internal,work_external | ||
| util_dist_to_nearest_ext_station,Distance to nearest external station,dist_to_external_zone,,coef_dist_to_nearest_ext_station | ||
| # FIXME just have a single external indicator not counts at the station here and in destination choice size terms,,,, | ||
| #util_size_of_nearest_ext_station,Size of nearest external station,"@np.log1p(reindex(land_use.external_work,df.closest_external_zone))",coef_size_of_nearest_ext_station, | ||
| util_size_of_nearest_ext_station,Size of nearest external station,"@np.log1p(reindex(land_use.EXTERNAL,df.closest_external_zone))",coef_size_of_nearest_ext_station, | ||
| util_dist_lt_2p5,Distance less than 2.5 miles,"@np.where(df.dist_to_external_zone<2.5,1,0)",coef_dist_lt_2p5, | ||
| util_part_time,Part time worker,"@np.where(df.pemploy == 2,1,0)",coef_part_time, | ||
| util_inc_lt15,Household Income less than $15k,@(df.income<15000),coef_inc_lt15, | ||
| util_inc_15_25,Household income $15k-$25k,@(df.income>=15000) & (df.income<25000) ,coef_inc_15_25, | ||
| util_inc_25_50,Household Income $25k-$50k,@(df.income>=25000) & (df.income<50000) ,coef_inc_25_50, | ||
| util_inc_150_250,Household Income $150k-$50k,@(df.income>=150000) * (df.income<250000) ,coef_inc_150_250, | ||
| util_inc_250plus,Household Income $250k+,@(df.income>=250000),coef_inc_250plus, | ||
| util_asc,Alternative-specific constant for external worker,1,asc_external_worker, | ||
| util_global_switch,Global switch to have everything internal,@NO_EXTERNAL,-999, | ||
| util_2016,Constant for pre-COVID conditions,@PRE_COVID,asc_external_2016, | ||
| util_calib,Constant for calibration,1,0.35, | ||
| #util_size_of_nearest_ext_station,Size of nearest external station,"@np.log1p(reindex(land_use.external_work,df.closest_external_zone))",,coef_size_of_nearest_ext_station | ||
| util_size_of_nearest_ext_station,Size of nearest external station,"@np.log1p(reindex(land_use.EXTERNAL,df.closest_external_zone))",,coef_size_of_nearest_ext_station | ||
| util_dist_lt_2p5,Distance less than 2.5 miles,"@np.where(df.dist_to_external_zone<2.5,1,0)",,coef_dist_lt_2p5 | ||
| util_part_time,Part time worker,"@np.where(df.pemploy == 2,1,0)",,coef_part_time | ||
| util_inc_lt15,Household Income less than $15k,@(df.income<15000),,coef_inc_lt15 | ||
| util_inc_15_25,Household income $15k-$25k,@(df.income>=15000) & (df.income<25000) ,,coef_inc_15_25 | ||
| util_inc_25_50,Household Income $25k-$50k,@(df.income>=25000) & (df.income<50000) ,,coef_inc_25_50 | ||
| util_inc_150_250,Household Income $150k-$50k,@(df.income>=150000) * (df.income<250000) ,,coef_inc_150_250 | ||
| util_inc_250plus,Household Income $250k+,@(df.income>=250000),,coef_inc_250plus | ||
| util_asc,Alternative-specific constant for external worker,1,,asc_external_worker | ||
| util_global_switch,Global switch to have everything internal,@NO_EXTERNAL,,-999 | ||
| util_2016,Constant for pre-COVID conditions,@PRE_COVID,,asc_external_2016 | ||
| util_calib,Constant for calibration,1,,0.35 |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also removes hard-coding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ISO format needed for sorting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,4 +201,5 @@ escort,shopping,othmaint,eatout,social,othdiscr | |
| 2,1,1,0,1,1 | ||
| 2,1,2,1,0,0 | ||
| 2,0,2,1,1,0 | ||
| 2,0,2,0,1,1 | ||
| 2,1,1,1,1,0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of change to externalize alternative selection (remove hard-coding alt)