Skip to content

fix(stdio): ensure compatibility with newlib <3.4.0 by handling removed __sdidinit #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supperthomas merged 3 commits into from
Oct 13, 2025
Merged

fix(stdio): ensure compatibility with newlib <3.4.0 by handling removed __sdidinit #10791

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fe00cb
Fix stdio compatibility with Newlib >= 3.4.0
loremmoqi Oct 11, 2025
443e5ba
Standard comments are in C++ style.
loremmoqi Oct 11, 2025
bf93762
delete extra space at the end of this line 109
loremmoqi Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/libc/posix/io/stdio/stdio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ int rt_posix_stdio_set_console(const char* device_name, int mode)
_GLOBAL_REENT->_stderr = std_console;
}

#if (NEWLIB_VERSION_NUM < 30400U) || (NEWLIB_VERSION_NUM >= 40000U && NEWLIB_VERSION_NUM < 40300U)
_GLOBAL_REENT->__sdidinit = 1; /* __sdidinit is obselete */
#if defined(_REENT_SMALL) || !defined(__sdidinit)
// Newlib >= 3.4.0 or small reent version: no __sdidinit field
// Do nothing
#else
// Older newlib versions (typically < 3.4.0) still define __sdidinit

Copilot AI Oct 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: The comment style should follow RT-Thread coding standards using C-style comments (/* */) instead of C++-style comments (//) for consistency with the existing codebase.\n\n中文: 注释风格应遵循 RT-Thread 编码标准，使用 C 风格注释（/* */）而不是 C++ 风格注释（//），以与现有代码库保持一致。

Suggested change
// Newlib >= 3.4.0 or small reent version: no __sdidinit field
// Do nothing
#else
// Older newlib versions (typically < 3.4.0) still define __sdidinit
/* Newlib >= 3.4.0 or small reent version: no __sdidinit field */
/* Do nothing */
#else
/* Older newlib versions (typically < 3.4.0) still define __sdidinit */

Copilot uses AI. Check for mistakes.

@Rbb666 Rbb666 Oct 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个麻烦作者修改下

@loremmoqi loremmoqi Oct 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@loremmoqi loremmoqi Oct 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

_GLOBAL_REENT->__sdidinit = 1;
#endif
}

Expand Down