Skip to content

26 integrate modular anns - #37

Open
PatrickHenkel1 wants to merge 69 commits into
mainfrom
26-integrate-modular-anns
Open

26 integrate modular anns#37
PatrickHenkel1 wants to merge 69 commits into
mainfrom
26-integrate-modular-anns

Conversation

@PatrickHenkel1

@PatrickHenkel1 PatrickHenkel1 commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Adds modular ANNs to physXAI. Modular ANNs allow more flexibility to create new models, e.g. subsystems with linear and non-linear inputs

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code change that neither fixes a bug nor adds a feature)
  • Documentation update

Required Checklist

Testing

  • Unit tests have been created/updated for new/modified functionality
  • CI/CD pipeline passes all tests (pytest, coverage, executables, installation)

Examples

  • Add examples for new features and functionality

Compatibility

  • Changes are backward compatible OR deprecation warnings added
  • No breaking changes to public APIs
  • New dependencies added to pyproject.toml (required in dependencies or optional in [project.optional-dependencies])

Documentation

  • Docstrings added/updated for new/modified public methods (Google style)
  • Type hints added for new functions/methods

Breaking Changes

Optional

GitHub Copilot Review

  • Request Copilot review via GitHub UI (add 'copilot' as a reviewer)

@PatrickHenkel1 PatrickHenkel1 linked an issue Nov 3, 2025 that may be closed by this pull request

super().__init__(name)
self.model = model
self.model.model_config.update({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model only has attribute model_config if model is of type ANNModel. However, LinearRegressionModel is in allowed models as well. The latter is only of type SingleStepModel but not of type ANNModel --> insert instance check before updating model_config

In addition: update type hint for model parameter in init header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate Modular ANNs

5 participants