26 integrate modular anns - #37
Open
PatrickHenkel1 wants to merge 69 commits into
Open
Conversation
…BC/physXAI into 26-integrate-modular-anns
…BC/physXAI into 26-integrate-modular-anns
…BC/physXAI into 26-integrate-modular-anns
SiAndRo2002
reviewed
Dec 28, 2025
|
|
||
| super().__init__(name) | ||
| self.model = model | ||
| self.model.model_config.update({ |
Collaborator
There was a problem hiding this comment.
model only has attribute model_config if model is of type ANNModel. However, LinearRegressionModel is in allowed models as well. The latter is only of type SingleStepModel but not of type ANNModel --> insert instance check before updating model_config
In addition: update type hint for model parameter in init header
…BC/physXAI into 26-integrate-modular-anns
…BC/physXAI into 26-integrate-modular-anns
…s-are-not-deterministic' into 26-integrate-modular-anns
…s-are-not-deterministic' into 26-integrate-modular-anns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds modular ANNs to physXAI. Modular ANNs allow more flexibility to create new models, e.g. subsystems with linear and non-linear inputs
Type of Change
Required Checklist
Testing
Examples
Compatibility
pyproject.toml(required independenciesor optional in[project.optional-dependencies])Documentation
Breaking Changes
Optional
GitHub Copilot Review