Remove sparql client dependency#3
Closed
nvdk wants to merge 53 commits into
Closed
Conversation
This is an extension to how the query and update functions work. It brings these functions a bit more in line with current use and could ease the path to using scopes instead of sudo where it's possible.
This was already in the documentation but it does not seem to have made it into the exports.
When there's a package.json with `"type": "module"`, this approach should support importing of esmodules. It is based on #PR38 and likely needs some extra polish.
Create a package.json if it does not exist yet. If it does exist, ensure there is a "type": "module" when no "type" was specified. Co-author: @erikap
… node instead of babel node to run when in development mode
…all so they can get rid of squiggly red lines too
Co-author: @erikap
- branching rather than early return - positive if clause (as a result of the former) - some questions in the code itself Co-author: @erikap
This doesn't seem necessary today and we're trying to somewhat limit the scope of the PR. This commit can be reverted if we do want this option. Readme is still to be drafted in that case. Co-author: @erikap
Ideally options have a positive variable name. Because we don't have a clear motivation why we would keep babel-node, we'd better remove it.
This is arguably easier to recognize. Co-author: @erikap
Revert this commit to add support for -clean again. Would require scripts/config.json to be updated with the optional argument and README information. PR indicated this to better be a manual user action for now. Co-author: @erikap
A bunch of services set the package-lock not to be created. The script would error on the last step in that case. That's not terrible, but code tastes better without crashes. Co-author: @erikap
noob comments but they may help a second reading Co-author: @erikap
Perhaps this will make it easier to understand next time, perhaps it's just the same in a different package. Doesn't look worse. Co-author: @erikap
Existing code, not related to the PR at hand. We want to delete sources which the user has deleted, except for the content in node_modules because we maintain part of those sources in the template. Co-author: @erikap
The current node version is sufficient for the way we wrote the code. The sourcemaps weren't generated in a way our language server configuration appreciated or babel doesn't generate what it expected. We can disable for now and turn it on again later if new game-changing features arrive. Co-author: @erikap
Likely to be renamed again, follow the trail for history. Co-author: @erikap
Co-author: @erikap
This reverts commit f0424f7.
This is not the approach we want to take in the end, but doing so allows to debug a bit better what is going on. We currently expect install-dependencies to become a script which consists of two steps which can also independently be called from other code paths.
Co-author: @erikap
Globbing could make things expand which were not intended thereby making arguments appear different than the supplied command. `--exclude '*.js'` could be globbed which is weird at best. Co-author: @erikap
This seems to be the way in which debuggers are happy so we're rolling with that for now.
No functional changes. Some comments were rewritten or resolved, tracing was disabled and some newline changes.
Used the external sourcemaps instead of the inline sourcemaps Co-author: @erikap
Avoids relative paths in the source maps
Strategically keep node_modules around. Use docker-rsync for more targeted copies. Co-author: @erikap
boot.sh was not balanced with the logic for development largely in a separate script and the logic for development mostly in the same script. Now we have a separate run-production.sh script called from boot.sh. Co-author: @erikap
this is a breaking change when coming from mu-auth-sudo, but brings the api of the query helpers in line with the api provided by the template
Author
|
closed in favour of mu-semtech#82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges origin/master and updates the branch to be inline with the api currently provided by the template. relevant commit (and changes) in 715f7fe