Skip to content

Make template policy tests configuration-agnostic #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nickfost merged 1 commit into from
Jul 14, 2026
Merged

Make template policy tests configuration-agnostic #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions templates/config-repository/scripts/test_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ def errors_for(config: dict, *, strict: bool = False) -> list[str]:
return validation.errors


def first_project(config: dict) -> dict:
return next(iter(config["projects"].values()))


class PolicyTests(unittest.TestCase):
def assert_rejected(self, config: dict, expected: str, *, strict: bool = False) -> None:
errors = errors_for(config, strict=strict)
Expand Down Expand Up @@ -64,26 +68,31 @@ def test_secret_value_key_is_rejected(self) -> None:
self.assert_rejected(config, "secret values are forbidden")

def test_strict_mode_rejects_unchanged_example(self) -> None:
self.assert_rejected(reference_config(), "replace the example organization", strict=True)
config = copy.deepcopy(reference_config())
project = first_project(config)
config["organization"]["slug"] = "example-org"
config["runner_pools"][project["ci_pool"]]["allowed_repositories"] = ["example-org/example-app"]
project["repository"] = "example-org/example-app"
self.assert_rejected(config, "replace the example organization", strict=True)

def test_nonstandard_ci_entrypoint_is_rejected(self) -> None:
config = copy.deepcopy(reference_config())
config["projects"]["example-app"]["ci_contract"]["aggregate_entrypoints"]["fast"] = "npm test"
first_project(config)["ci_contract"]["aggregate_entrypoints"]["fast"] = "npm test"
self.assert_rejected(config, "standard aggregate fast entrypoint")

def test_job_ceiling_above_five_minutes_is_rejected(self) -> None:
config = copy.deepcopy(reference_config())
config["projects"]["example-app"]["ci_contract"]["max_job_minutes"] = 10
first_project(config)["ci_contract"]["max_job_minutes"] = 10
self.assert_rejected(config, "five-minute hard job ceiling")

def test_shard_target_must_reserve_startup_time(self) -> None:
config = copy.deepcopy(reference_config())
config["projects"]["example-app"]["ci_contract"]["shard_target_minutes"] = 5
first_project(config)["ci_contract"]["shard_target_minutes"] = 5
self.assert_rejected(config, "reserve startup time")

def test_standard_task_plan_path_is_required(self) -> None:
config = copy.deepcopy(reference_config())
config["projects"]["example-app"]["ci_contract"]["task_plan"] = "ci/custom.json"
first_project(config)["ci_contract"]["task_plan"] = "ci/custom.json"
self.assert_rejected(config, "standard task-plan path")


Expand Down