Skip to content

Automate GitHub App and runner-group bootstrap - #75

Draft
Nickfost wants to merge 10 commits into
mainfrom
feat/issue-27-github-bootstrap
Draft

Automate GitHub App and runner-group bootstrap#75
Nickfost wants to merge 10 commits into
mainfrom
feat/issue-27-github-bootstrap

Conversation

@Nickfost

Copy link
Copy Markdown
Member

Closes #27

Summary

  • add a local GitHub App manifest callback with state-bound conversion and immediate private-key handoff
  • add idempotent check/dry-run/live bootstrap for installation identity, runner-group allow-listing, and repository access
  • add mocked REST/callback regressions, redaction, cleanup, installer handoff, and an operator runbook

Validation

  • scripts/test-bootstrap-github.sh
  • Bash syntax and ShellCheck
  • Python compilation
  • documentation links and quickstart contract
  • committed-secret scan
  • scripts/validate.sh reached INSTALLER_TESTS_OK and STATUS_RECEIVER_INSTALL_TESTS_OK; final Docker smoke was omitted because this authorized repository-only environment has no Docker CLI/daemon (docker: command not found)

External gate

Draft: an organization owner must create/install the App and approve the runner-group mutation in a prepared browser/API session. This run did not create an App, change runner groups, install credentials, or mutate live infrastructure.

@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head f59bdaa for trust-boundary safety, credential cleanup/redaction, idempotence, and mocked acceptance coverage.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f59bdaae62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 89d79ac after all eight accepted bootstrap findings: loopback confidentiality, public-runner rejection, fail-closed pagination, selected-only installation, refreshed JWTs, recoverable conversion, durable instance identity, and installer-compatible IDs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89d79ace17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread docs/GITHUB-APP-SETUP.md Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh
Comment thread docs/GITHUB-APP-SETUP.md
Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 831844a after the accepted recovery, scope-separation, runner-group-contract, and callback fixes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 831844a2aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 4fbb184 after closing the four accepted bootstrap verification findings: project name/ID prevalidation, persisted client-ID verification, installer/App repository matching, and effective contents permission.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4fbb184683

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head e3ea10a after replacing config-token project prevalidation with organization runner-group verification and transactional rollback.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3ea10a39d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 7255a7c after archived-project rejection, cancellation rollback, rollback documentation, pinned-local installer handoff, and exact desired-state routing validation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7255a7c323

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 73ab465 after complete pinned-configuration validation and child-job-safe callback reaping.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73ab465534

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh
Comment thread scripts/bootstrap-github.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 5b7eebb after parent-bound callback lifetime, bounded API transfers, unsafe-state rejection, and host-local transaction locking.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b7eebb4c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github-callback.py Outdated
Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head fb6b12c after atomic lock creation, explicit callback parent binding, and complete runner-group repository pagination.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb6b12c794

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bootstrap-github.sh Outdated
Comment thread scripts/bootstrap-github.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please confirm exact head 113bad0 after ambiguous recovery preservation and mutually exclusive mode parsing.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 113bad047d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate GitHub App and runner-group bootstrap with Bash

1 participant