Skip to content
This repository was archived by the owner on Jul 12, 2026. It is now read-only.

Release/9.19.0rc2 - #849

Closed
ibraheem-abe wants to merge 166 commits into
mainfrom
release/9.19.0rc2
Closed

ibraheem-abe wants to merge 166 commits into
mainfrom
release/9.19.0rc2

Conversation

@ibraheem-abe

Copy link
Copy Markdown
Contributor

9.19.0rc2 /2026-03-03

What's Changed

New Contributors

Full Changelog: v9.18.1...v9.19.0rc2

thewhaleking and others added 30 commits October 27, 2025 23:15
Replace overly broad `except Exception` catches with specific exception types
to improve error handling clarity and debugging:

- subtensor_interface.py: Handle both TimeoutError and asyncio.TimeoutError
  for substrate initialization timeout (resolves TODO comment)
- utils.py (is_valid_github_url): Catch ValueError, TypeError, AttributeError
  for URL parsing exceptions (resolves TODO comment)
- utils.py (normalize_hyperparameters): Catch KeyError, ValueError, TypeError,
  AttributeError for parameter normalization
- wallets.py (new_hotkey): Catch ValueError, TypeError for Keypair.create_from_uri
- wallets.py (new_coldkey): Catch ValueError, TypeError for Keypair.create_from_uri
- wallets.py (wallet_create): Catch ValueError, TypeError, KeyFileError for
  keypair and wallet creation

This change improves code quality by making exception handling more explicit
and easier to debug while maintaining the same error recovery behavior.
Per reviewer feedback: bittensor_wallet.Keypair.create_from_uri() only raises
TypeError, not ValueError. Removed ValueError from exception tuples on lines
380 and 431.
thewhaleking
thewhaleking previously approved these changes Mar 3, 2026
thewhaleking
thewhaleking previously approved these changes Mar 3, 2026
basfroman
basfroman previously approved these changes Mar 3, 2026
@ibraheem-abe
ibraheem-abe dismissed stale reviews from basfroman and thewhaleking March 20, 2026 10:10

The merge-base changed after approval.

This branch was previously deployed

1 inactive deployment
release — acbd12d2 Deployed Mar 4, 2026 by ibraheem-abe via approve-and-publish #88
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants