-
Notifications
You must be signed in to change notification settings - Fork 220
chore!: bundle CLI with esbuild #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlbinaBlazhko17
wants to merge
37
commits into
main
Choose a base branch
from
feat/esbuild-bundle-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
24a6fdb
chore: use esbuild to bundle cli
AlbinaBlazhko17 23c1b35
refactor: comments, naming and script
AlbinaBlazhko17 64c8287
chore: change comments
AlbinaBlazhko17 13097cb
fix: failed smoke tests
AlbinaBlazhko17 e284f86
fix: add missing binTargetPath
AlbinaBlazhko17 79ae229
chore: remove unused enableCrossOsArchive
AlbinaBlazhko17 5d77530
Merge branch 'main' into feat/esbuild-bundle-cli
AlbinaBlazhko17 f130d53
chore: try to remove compile from the smoke test
AlbinaBlazhko17 3c0b344
Merge branch 'main' into feat/esbuild-bundle-cli
AlbinaBlazhko17 dd3993a
chore: retrigger CI
AlbinaBlazhko17 2d61a33
chore: trigger workflow
AlbinaBlazhko17 8334e58
fix: failing smoke tests
AlbinaBlazhko17 f7f2194
Revert "fix: failing smoke tests"
AlbinaBlazhko17 9bf261a
chore: trigger CI
AlbinaBlazhko17 b91c75e
chore: add dot
AlbinaBlazhko17 e14b327
feat: add code splitting into chuncs by dynamic imports and add dynam…
AlbinaBlazhko17 b37d33f
chore: remove unused deps due to bundle
AlbinaBlazhko17 400e935
feat: move all deps to the devDep
AlbinaBlazhko17 53b1f55
fix: resolving path to plugin
AlbinaBlazhko17 79e4768
fix: failed test
AlbinaBlazhko17 dd57cea
chore: clean lib folder before build
AlbinaBlazhko17 dc2437d
fix: bumping versions
AlbinaBlazhko17 fdb23b6
fix: pipeline, scripts, plugin-evaluator and add THIRD_PARTY_NOTICES
AlbinaBlazhko17 9ad62f7
chore: deslope
AlbinaBlazhko17 6e280d0
chore: run format
AlbinaBlazhko17 f70d6e8
fix: e2e script, build third party license, remove template, test and…
AlbinaBlazhko17 7a6e98b
chore: run formatter
AlbinaBlazhko17 51376ca
chore: update e2e script
AlbinaBlazhko17 4cde987
chore: change target in esbuild
AlbinaBlazhko17 dae6bf5
fix: change target and refactor import of redoc version
AlbinaBlazhko17 bb5965a
Merge branch 'main' into feat/esbuild-bundle-cli
AlbinaBlazhko17 bfad5ac
chore: uncomment smokes
AlbinaBlazhko17 4b7d5bd
chore: comment smoke due to failing
AlbinaBlazhko17 c525d5e
chore: remove comments
AlbinaBlazhko17 23deb7d
fix: issue with abs path in windows
AlbinaBlazhko17 ba2c5eb
Merge branch 'main' into feat/esbuild-bundle-cli
AlbinaBlazhko17 7092545
chore: update lock file
AlbinaBlazhko17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@redocly/cli': patch | ||
| --- | ||
|
|
||
| Improved CLI install speed by bundling the CLI into a dependency-free package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,7 @@ | |
| !tsconfig.build.json | ||
| !tsconfig.json | ||
| !package-lock.json | ||
| !README.md | ||
| !LICENSE.md | ||
| !packages/* | ||
| !scripts/local-pack.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,10 @@ FROM node:24-alpine | |
| WORKDIR /build | ||
| COPY . . | ||
| RUN apk add --no-cache jq git && \ | ||
| npm ci --no-optional --ignore-scripts && \ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need to skip deps under |
||
| npm ci --ignore-scripts && \ | ||
| npm run prepare && \ | ||
| npm run pack:prepare && \ | ||
| npm install --global redocly-cli.tgz && \ | ||
| cp packages/cli/src/commands/build-docs/template.hbs \ | ||
| /usr/local/lib/node_modules/@redocly/cli/lib/commands/build-docs/ && \ | ||
| # Clean up to reduce image size | ||
| npm cache clean --force && rm -rf /build | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have root
LICENSE.mdfile with this extension.