feat(rfq): add authenticated provider protocol - #35
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9b3b98512
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| endpoint, | ||
| connection, | ||
| inbound_budget: InboundBudget::new(config.inbound_budget_bytes), | ||
| in_flight: Arc::new(Semaphore::new(config.max_in_flight_requests)), |
There was a problem hiding this comment.
Reject semaphore counts above Tokio's limit
When a caller supplies max_in_flight_requests > Semaphore::MAX_PERMITS, configuration validation accepts it, but this constructor panics instead of returning ClientError::InvalidConfig; the equivalent server construction also affects max_in_flight_requests, while Server::run can panic for an oversized max_connections. Validate these public configuration values against Tokio's limit before constructing the semaphores so an operator-provided value cannot crash the process.
Useful? React with 👍 / 👎.
Summary
deadcat-rfq/1ALPN with persistent identities, operation-wide deadlines, concurrency limits, and authenticated peer dispatchSafety boundaries
Executehandler must hand post-commit signing, persistence, and relay to daemon-owned recovery work before crossing the durable point of no return, because transport timeouts cancel handler futuresVerification
cargo fmt --all -- --checkgit diff --checkcargo clippy --locked --offline --workspace --all-targets -- -D warningscargo test --locked --offline --workspace --all-targets -- --test-threads=1Stack
This PR is intentionally based on #34 and contains exactly one additional commit. Once #34 merges, this PR can be retargeted to
master.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.