feat(rfq): complete taker settlement authorization - #39
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 234334ebdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub id: u16, | ||
| pub outpoint: OutPoint, | ||
| pub witness_utxo: TxOutDto, | ||
| pub internal_key: FixedBytes32, |
There was a problem hiding this comment.
Version the incompatible quote-input wire change
Adding this required field changes both the strict deny_unknown_fields JSON DTO and the signed canonical quote transcript, but SCHEMA_VERSION, ALPN, QUOTE_ATTESTATION_DOMAIN, and CanonicalFirmQuoteV1 remain at v1. During a mixed-version deployment, old clients reject new quotes as containing an unknown field and new clients cannot decode old quotes because the field is missing, even though both peers advertise the same protocol version; bump the wire/attestation version so this incompatibility is detected at negotiation rather than as a generic decode failure.
Useful? React with 👍 / 👎.
Summary
SIGHASH_ALLTaproot signatures, and fee/weight limitsSafety boundaries
SIGHASH_ALLA production taker wallet/source adapter, wallet input/change selection, broadcast, and confirmation monitoring remain follow-up work.
Verification
cargo fmt --all -- --checkcargo clippy --locked --offline --workspace --all-targets -- -D warningscargo test --locked --offline --workspace --all-targets -- --test-threads=1cargo test --locked --offline --workspace --docA separate security review found no remaining launch-blocking issue in this slice.
Stack
This PR contains one commit on top of #38 (
codex/rfq-taker-client). Retarget it to the eventual merged base after #38 lands.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.