feat(rfq): bind taker journal to wallet state - #44
Open
tvolk131 wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety properties
Verification
cargo test --workspacecargo check --workspace --all-targetscargo test -p deadcat-rfq-client --test session_routecargo test -p deadcat-rfq-takercargo test -p deadcat-rfq-wallet wallet_instance_id_derivation_is_stable_and_binds_every_inputcargo fmt --all -- --checkgit diff --checkStrict Clippy was attempted through the Nix development shell, but Nix could not download
base58ckbecause crates.io returned HTTP 403. Ordinary all-target compilation and the complete workspace suite pass.Stacked on #43.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.