Skip to content

Split auto-evo mutation generation into substeps #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RyuDanuer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Split auto-evo mutation generation into substeps #6946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd953df
Split auto-evo mutation generation into substeps
RyuDanuer Apr 28, 2026
c26b02d
Preserve auto-evo mutation behavior
RyuDanuer Apr 28, 2026
63b0b0c
Use interlocked auto-evo step estimate update
RyuDanuer Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/auto-evo/AutoEvoRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,8 @@ private bool Step()
{
GatherInfo(runSteps);

// +2 is for this step and the result apply step
totalSteps = runSteps.Sum(s => s.TotalSteps) + 2;

Interlocked.Increment(ref completeSteps);
UpdateTotalStepsEstimate();
state = RunStage.Stepping;
return false;
}
Expand Down Expand Up @@ -625,6 +623,8 @@ private bool Step()
}
}

UpdateTotalStepsEstimate();

return false;
}

Expand Down Expand Up @@ -665,6 +665,21 @@ private void RunSingleStepToCompletion(IRunStep step)
Interlocked.Add(ref completeSteps, steps);
}

private void UpdateTotalStepsEstimate()
{
var estimate = CompleteSteps + runSteps.Sum(s => s.TotalSteps) + 1;
Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this would break all other auto-evo steps than the one you modified.

Also rather than locking just for an int, compare exchange or other interlocked methods should be used.

Overall this still looks like a major LLM mess I'm not sure I will have the mental energy to review anytime soon.

Copy link
Copy Markdown
Contributor Author

@RyuDanuer RyuDanuer Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the lock with an Interlocked.CompareExchange loop, so the total step estimate still only moves upward but doesn’t use a lock just for the int update. This keeps the volatile/threaded behavior intact while addressing the review point.

Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't address the fact that other auto-evo step types likely will not work correctly as their CompletedSteps assumes it approaches and reaches the total steps it reports and not like this.

I'm tired of trying to explain to you that bigger changes that touch the overall code architecture of Thrive need a lot more careful manual review than you are doing.

It might be the case that ModifyExistingSpecies.cs is converted reasonably and works without excessive temporary memory usage, but I'm tired of looking at AI PRs again and again when it would be faster for me to just redo the work from scratch.

For human programmers who want to get into Thrive I will try my hardest to provide constructive feedback on their PRs so that they might improve and in the future become a net contributor (or at least walk away from Thrive with some valuable experience on their programming career). But for your PRs I doubt they are going to get any better as I'm still needing to mention that you can't just let the AI run wild as it will not care about code uniformity or properly structuring code changes to fit in with existing code.

int current;

do
{
current = totalSteps;

if (estimate <= current)
return;
}
while (Interlocked.CompareExchange(ref totalSteps, estimate, current) != current);
}

private void UpdateMap(bool playerCantGoExtinct)
{
Parameters.World.Map.UpdateGlobalTimePeriod(Parameters.World.TotalPassedTime);
Expand Down
Loading