Skip to content

Rebalance Double membrane type#6964

Merged
hhyyrylainen merged 8 commits into
masterfrom
Double-membrane-rebalance
May 12, 2026
Merged

Rebalance Double membrane type#6964
hhyyrylainen merged 8 commits into
masterfrom
Double-membrane-rebalance

Conversation

@Accidental-Explorer
Copy link
Copy Markdown
Contributor

@Accidental-Explorer Accidental-Explorer commented Apr 30, 2026

Brief Description of What This PR Does
For the "Double" membrane:

  • Remove osmoregulation discount
  • decrease health
  • Increase toxin resistance

So the Double membrane is now a variant of "Normal" that sacrifices some speed for increased defense, but especially against toxins. (This is also effective against engulfed toxic cells).

This will also require a re-write of the tooltip, which I will do if/when the rest of the change is approved.

Related Issues

Double membrane type is a bit of a bland upgrade to Normal.

Desire among the community for more ways to counter toxins.

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR). This includes gameplay testing by the PR author.
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen
Copy link
Copy Markdown
Member

I'll comment here while I still remember that Iman tested this and shared some feedback on Discord. I think the feedback was asking for further tweaks as this didn't yet seem ready.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

I'll comment here while I still remember that Iman tested this and shared some feedback on Discord. I think the feedback was asking for further tweaks as this didn't yet seem ready.

Yes, I'm currently focusing on other PRs when I have time, but I can probably give this a tweak and give it another go. I'm thinking to increase Toxin resistance more, to really make it fill that role. But I might have to rebalance some other membrane types slightly to match.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

This was approved in testing, so I figured I would add the localization so it can be merged. But looks like I tried right at the wrong time?

@hhyyrylainen
Copy link
Copy Markdown
Member

Well I just merged the spore reproduction PR which had new translations, so yeah.

I'll fix Weblate in a bit by merging its changes directly to master, so you might want to wait a few minutes before fixing the translations again on this PR.

@hhyyrylainen
Copy link
Copy Markdown
Member

Should be safe to update this now.

@hhyyrylainen
Copy link
Copy Markdown
Member

hhyyrylainen commented May 12, 2026

Well @Deus-Codes has not commented on this as far as I remember, but I guess we do want this change merged for the next release?

Edit: Iman has tested this on Discord

Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical side of things looks fine.

@hhyyrylainen hhyyrylainen merged commit 607fffe into master May 12, 2026
4 checks passed
@hhyyrylainen hhyyrylainen deleted the Double-membrane-rebalance branch May 12, 2026 06:42
@github-project-automation github-project-automation Bot moved this from In progress to Done in Thrive Planning May 12, 2026
@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

Well @Deus-Codes has not commented on this as far as I remember, but I guess we do want this change merged for the next release?

Well, he has not tested it, but he was supportive of the ideas I put forth before I started.

But I see you already merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants