Skip to content

Credits fast forward#6975

Open
Bupman wants to merge 1 commit intoRevolutionary-Games:masterfrom
Bupman:master
Open

Credits fast forward#6975
Bupman wants to merge 1 commit intoRevolutionary-Games:masterfrom
Bupman:master

Conversation

@Bupman
Copy link
Copy Markdown

@Bupman Bupman commented May 5, 2026

Add fast forward to credits. Press F to do so. I'm not sure if I'm doing this right

Add fast forward to credits. Press F to do so.
@revolutionary-bot
Copy link
Copy Markdown

Thank you for contributing to Thrive.

Before your contribution can be accepted, you need to sign our CLA.
You can sign it, and find more info about it, here: https://dev.revolutionarygamesstudio.com/cla

Once your contribution has been accepted you can ask to be included in the credits (https://wiki.revolutionarygamesstudio.com/wiki/Team_Members) and you can apply to join the team and use this work as a sample: https://revolutionarygamesstudio.com/application/

Copy link
Copy Markdown
Member

@dligr dligr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Thrive! There are two issues that I've noticed that need to be addressed before the PR is merged

private const bool ShowAssociationName = true;
private const bool ShowFullLicenseTexts = false;
private const bool ShowAssociationName = true;
private const bool ShowFullLicenseTexts = false;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file's spaces were converted to tabs (this might have been done automatically by an IDE). Thrive's style guide requires indentation to use spaces.

if (!scrolling || phase == CreditsPhase.NotRunning)
return;

var CurrentScrollSpeed = Input.IsKeyPressed(Key.F)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thrive uses its own input system, this doc descibes how to use it:
https://github.com/Revolutionary-Games/Thrive/blob/master/doc/input_system.md

Basically, you should add a custom new Action to the Godot Project and use it with one of the attributes listed in the doc (in a separate function not to interfere with _Process). This script should also inherit from the ControlWithInput class instead of Control.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor

Welcome!

Just to make sure, did you run all the way through https://github.com/Revolutionary-Games/Thrive/blob/master/doc/setup_instructions.md ?

I think it helps you get the right settings to avoid things like the tabs.

@hhyyrylainen
Copy link
Copy Markdown
Member

I see some other people already jumped on this, but I also wanted to say welcome, and point out a few more things:

  • The pull request template text should not be deleted so that we can use the workflow checklist in it to track PR status (please keep this in mind for future PRs)
  • In addition to using our custom input system, the keybinding might be good to add to our input_options.json file (probably in a new section) so that the player can rebind / see the fast forward key. And that requires a translations file update, which is described in this document: https://github.com/Revolutionary-Games/Thrive/blob/master/doc/working_with_translations.md

@Bupman Bupman closed this May 6, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in Thrive Planning May 6, 2026
@Bupman Bupman reopened this May 6, 2026
@github-project-automation github-project-automation Bot moved this from Done to In progress in Thrive Planning May 6, 2026
@Bupman
Copy link
Copy Markdown
Author

Bupman commented May 6, 2026

i did not mean to close, i misread and thought it would close comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

5 participants