Credits fast forward#6975
Conversation
Add fast forward to credits. Press F to do so.
|
Thank you for contributing to Thrive. Before your contribution can be accepted, you need to sign our CLA. Once your contribution has been accepted you can ask to be included in the credits (https://wiki.revolutionarygamesstudio.com/wiki/Team_Members) and you can apply to join the team and use this work as a sample: https://revolutionarygamesstudio.com/application/ |
dligr
left a comment
There was a problem hiding this comment.
Thank you for contributing to Thrive! There are two issues that I've noticed that need to be addressed before the PR is merged
| private const bool ShowAssociationName = true; | ||
| private const bool ShowFullLicenseTexts = false; | ||
| private const bool ShowAssociationName = true; | ||
| private const bool ShowFullLicenseTexts = false; |
There was a problem hiding this comment.
It looks like this file's spaces were converted to tabs (this might have been done automatically by an IDE). Thrive's style guide requires indentation to use spaces.
| if (!scrolling || phase == CreditsPhase.NotRunning) | ||
| return; | ||
|
|
||
| var CurrentScrollSpeed = Input.IsKeyPressed(Key.F) |
There was a problem hiding this comment.
Thrive uses its own input system, this doc descibes how to use it:
https://github.com/Revolutionary-Games/Thrive/blob/master/doc/input_system.md
Basically, you should add a custom new Action to the Godot Project and use it with one of the attributes listed in the doc (in a separate function not to interfere with _Process). This script should also inherit from the ControlWithInput class instead of Control.
|
Welcome! Just to make sure, did you run all the way through https://github.com/Revolutionary-Games/Thrive/blob/master/doc/setup_instructions.md ? I think it helps you get the right settings to avoid things like the tabs. |
|
I see some other people already jumped on this, but I also wanted to say welcome, and point out a few more things:
|
|
i did not mean to close, i misread and thought it would close comment. |
Add fast forward to credits. Press F to do so. I'm not sure if I'm doing this right