Skip to content

Made failure to emit before membrane is ready a non-error print#6979

Merged
hhyyrylainen merged 1 commit intomasterfrom
non_serious_skipped_ejects
May 8, 2026
Merged

Made failure to emit before membrane is ready a non-error print#6979
hhyyrylainen merged 1 commit intomasterfrom
non_serious_skipped_ejects

Conversation

@hhyyrylainen
Copy link
Copy Markdown
Member

Brief Description of What This PR Does

and adjusted some code to better take into account ejections failing

Basically this reduces the severity of one non-serious error print

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR). This includes gameplay testing by the PR author.
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

and adjusted some code to better take into account ejections failing
@hhyyrylainen hhyyrylainen added this to the Release 1.1.0 milestone May 7, 2026
@hhyyrylainen hhyyrylainen requested a review from xfractalino May 7, 2026 18:04
@github-project-automation github-project-automation Bot moved this to In progress in Thrive Planning May 7, 2026
@hhyyrylainen hhyyrylainen merged commit 65ce215 into master May 8, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Thrive Planning May 8, 2026
@hhyyrylainen hhyyrylainen deleted the non_serious_skipped_ejects branch May 8, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant