Add builds for EasyNav + NavMap + PlanSys2 - #260 - #94
Conversation
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
|
Hey @fmrico could you fix the conflicts? I believe this should not be to hard now. |
|
Sorry for introducing those! Please postpend the comment to |
done
I think it is resolved by dependencies, right? |
There was a problem hiding this comment.
Pull request overview
This PR extends the build selection and dependency patching to bring EasyNav (EasyNavigation), NavMap, and PlanSys2 (plus related components) into the RoboStack ROS Kilted build workflow, currently scoped to Linux-only.
Changes:
- Add a Linux-only seed list in
vinca.yamlfor EasyNav/NavMap/PlanSys2 packages. - Add
patch/dependencies.yamloverrides to satisfy missing/implicit host/run deps for select EasyNav packages. - Introduce a
navmap_rospatch intended to avoid system Eigen include path leakage via PCL.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vinca.yaml | Adds a Linux-only selection block to include EasyNav/NavMap/PlanSys2 packages in the build set. |
| patch/ros-kilted-navmap-ros.patch | Adds CMake logic intended to prefer conda/pixi Eigen and filter system Eigen from PCL include dirs. |
| patch/dependencies.yaml | Adds dependency overrides for select EasyNav packages and ensures popf build dependency is declared. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| +# PCLConfig.cmake may inject system Eigen include paths; filter them out to | ||
| +# prevent mixing system Eigen with the conda/pixi Eigen. | ||
| if(PCL_INCLUDE_DIRS) | ||
| # Be permissive: the entry may have a trailing slash or whitespace depending | ||
| # on how PCL was configured. | ||
| list(FILTER PCL_INCLUDE_DIRS EXCLUDE REGEX "/usr/include/eigen3") | ||
| endif() |
Hi,
This PR contains:
rosdistro_snapshot.yamlI hope it helps!!