feat(media-call): save sip metadata to the media-call#40500
Open
pierre-lehnen-rc wants to merge 5 commits into
Open
feat(media-call): save sip metadata to the media-call#40500pierre-lehnen-rc wants to merge 5 commits into
pierre-lehnen-rc wants to merge 5 commits into
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 243bdbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThreads an optional sipCallId from SIP providers through CallDirector into persisted IMediaCall documents, exposes sipCallId in test fixtures, adds an authenticated GET /media-calls.info endpoint that returns a call when the requester is a participant, and adds end-to-end tests and a changeset. ChangesSIP call identifier threading and media-calls.info endpoint
sequenceDiagram
participant IncomingSipCall
participant CallDirector
participant OutgoingSipCall
participant MediaCalls
IncomingSipCall->>CallDirector: createCall(metadata.sipCallId = Call-ID header)
CallDirector->>MediaCalls: persist IMediaCall (includes sipCallId)
OutgoingSipCall->>CallDirector: acceptCall({ sipCallId: dialog.callId, ... })
CallDirector->>MediaCalls: acceptCallById(callId, { calleeContractId, supportedFeatures, sipCallId })
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40500 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 3353 3353
Lines 128820 128820
Branches 22294 22342 +48
========================================
Hits 90132 90132
- Misses 35397 35399 +2
+ Partials 3291 3289 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
coderabbitai
Bot
added
the
type: feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/core-typings/src/mediaCalls/IMediaCall.ts`:
- Around line 72-76: The IMediaCall interface currently requires metadata which
breaks compatibility with existing media_calls that may lack it; update the
interface so metadata is optional (e.g., change the property declaration for
metadata on IMediaCall to be optional) and ensure any code that dereferences
call.metadata (call.metadata.sipCallId, etc.) guards for undefined or uses a
safe default; refer to the IMediaCall type and any consumers that access
call.metadata when making this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1f0a4559-489f-4080-84cb-1879d6751802
📒 Files selected for processing (7)
apps/meteor/server/startup/callHistoryTestData.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tsee/packages/media-calls/src/sip/providers/OutgoingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/model-typings/src/models/IMediaCallsModel.tspackages/models/src/models/MediaCalls.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (3/4)
- GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (4/4)
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (5/5)
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (4/5)
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (3/5)
- GitHub Check: 🔨 Test API Livechat (CE) / MongoDB 8.0 (1/1)
- GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (2/4)
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (2/5)
- GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (1/5)
- GitHub Check: 🔨 Test Federation Matrix
- GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (1/4)
- GitHub Check: 🔨 Test API (CE) / MongoDB 8.0 (1/1)
- GitHub Check: 🔨 Test API Livechat (EE) / MongoDB 8.0 coverage (1/1)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
ee/packages/media-calls/src/sip/providers/OutgoingSipCall.tsapps/meteor/server/startup/callHistoryTestData.tspackages/model-typings/src/models/IMediaCallsModel.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/models/src/models/MediaCalls.tsee/packages/media-calls/src/server/CallDirector.ts
🧠 Learnings (3)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
ee/packages/media-calls/src/sip/providers/OutgoingSipCall.tsapps/meteor/server/startup/callHistoryTestData.tspackages/model-typings/src/models/IMediaCallsModel.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/models/src/models/MediaCalls.tsee/packages/media-calls/src/server/CallDirector.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
ee/packages/media-calls/src/sip/providers/OutgoingSipCall.tsapps/meteor/server/startup/callHistoryTestData.tspackages/model-typings/src/models/IMediaCallsModel.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/models/src/models/MediaCalls.tsee/packages/media-calls/src/server/CallDirector.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
ee/packages/media-calls/src/sip/providers/OutgoingSipCall.tsapps/meteor/server/startup/callHistoryTestData.tspackages/model-typings/src/models/IMediaCallsModel.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/models/src/models/MediaCalls.tsee/packages/media-calls/src/server/CallDirector.ts
🔇 Additional comments (6)
packages/model-typings/src/models/IMediaCallsModel.ts (1)
25-29: LGTM!packages/models/src/models/MediaCalls.ts (1)
92-101: LGTM!Also applies to: 114-114
ee/packages/media-calls/src/server/CallDirector.ts (1)
27-27: LGTM!Also applies to: 65-70, 242-242
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts (1)
102-114: LGTM!ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts (1)
272-276: LGTM!apps/meteor/server/startup/callHistoryTestData.ts (1)
137-137: LGTM!Also applies to: 171-171, 205-205, 239-239
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/meteor/app/api/server/v1/media-calls.ts (1)
252-254: ⚡ Quick winAdd 401/403 response schemas to
media-calls.infofor contract parity.This authenticated route currently omits
401and403validators even though other authenticated media-calls routes in this file include them.Proposed diff
response: { call: IMediaCall; }>({ @@ }), + 401: validateUnauthorizedErrorResponse, + 403: validateForbiddenErrorResponse, },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/app/api/server/v1/media-calls.ts` around lines 252 - 254, The media-calls.info route response object is missing 401 and 403 validators; update the responses map in media-calls.info to add entries for 401 and 403 using the same validator functions used elsewhere (e.g., validateUnauthorizedResponse and validateForbiddenResponse) alongside the existing 400 and 404 entries so contract parity is maintained.packages/apps/tests/test-data/utilities.ts (1)
508-542: ⚡ Quick winInclude
sipCallIdin the default media-call fixture.This helper is likely reused by accessor tests in this SIP-metadata PR, and omitting
sipCallIdmakes the default fixture miss the new field unless every test overrides it manually.Proposed change
public static getMediaCall(): IMediaCall { return { _id: 'first-call', _updatedAt: new Date(), service: 'webrtc', kind: 'direct', state: 'hangup', + sipCallId: 'sip-call-id-123', createdBy: { type: 'user', id: 'johnId', },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/apps/tests/test-data/utilities.ts` around lines 508 - 542, The default media-call fixture returned by getMediaCall() is missing the new sipCallId field; update the IMediaCall object in getMediaCall to include a sipCallId property (e.g., a string like 'sip-first-call' or similar) so tests that rely on the new SIP metadata field get a sensible default without needing to override it everywhere.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/apps/src/server/accessors/MediaCallRead.ts`:
- Around line 12-13: Change the method signature of MediaCallRead.getById to
match the interface IMediaCallRead.getById by returning Promise<IMediaCall |
undefined> and propagate nullable results from mediaCallBridge.doGetById (which
may return null) as undefined; update the return type in the getById declaration
and ensure any direct return of mediaCallBridge.doGetById(id, this.appId) is
typed/converted to IMediaCall | undefined so the implementation and interface
signatures align.
---
Nitpick comments:
In `@apps/meteor/app/api/server/v1/media-calls.ts`:
- Around line 252-254: The media-calls.info route response object is missing 401
and 403 validators; update the responses map in media-calls.info to add entries
for 401 and 403 using the same validator functions used elsewhere (e.g.,
validateUnauthorizedResponse and validateForbiddenResponse) alongside the
existing 400 and 404 entries so contract parity is maintained.
In `@packages/apps/tests/test-data/utilities.ts`:
- Around line 508-542: The default media-call fixture returned by getMediaCall()
is missing the new sipCallId field; update the IMediaCall object in getMediaCall
to include a sipCallId property (e.g., a string like 'sip-first-call' or
similar) so tests that rely on the new SIP metadata field get a sensible default
without needing to override it everywhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: effc24f8-1bfc-464c-9fc1-c5781bf1e777
📒 Files selected for processing (31)
apps/meteor/app/api/server/v1/media-calls.tsapps/meteor/app/apps/server/bridges/bridges.jsapps/meteor/app/apps/server/bridges/mediaCalls.tsapps/meteor/server/startup/callHistoryTestData.tsapps/meteor/tests/end-to-end/api/media-calls.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tsee/packages/media-calls/src/sip/providers/OutgoingSipCall.tspackages/apps-engine/src/definition/accessors/IMediaCallRead.tspackages/apps-engine/src/definition/accessors/IRead.tspackages/apps-engine/src/definition/accessors/index.tspackages/apps-engine/src/definition/mediaCalls/IMediaCall.tspackages/apps-engine/src/definition/mediaCalls/index.tspackages/apps/deno-runtime/lib/accessors/mod.tspackages/apps/src/AppsEngine.tspackages/apps/src/server/accessors/MediaCallRead.tspackages/apps/src/server/accessors/Reader.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/managers/AppAccessorManager.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps/tests/server/accessors/MediaCallRead.test.tspackages/apps/tests/server/accessors/Reader.test.tspackages/apps/tests/test-data/bridges/appBridges.tspackages/apps/tests/test-data/bridges/mediaCallBridge.tspackages/apps/tests/test-data/utilities.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/model-typings/src/models/IMediaCallsModel.tspackages/models/src/models/MediaCalls.ts
✅ Files skipped from review due to trivial changes (3)
- packages/apps-engine/src/definition/accessors/index.ts
- packages/apps/tests/server/accessors/MediaCallRead.test.ts
- packages/apps-engine/src/definition/mediaCalls/index.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/model-typings/src/models/IMediaCallsModel.ts
- ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
packages/apps/tests/server/accessors/Reader.test.tspackages/apps/src/AppsEngine.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/managers/AppAccessorManager.tsapps/meteor/app/api/server/v1/media-calls.tspackages/apps/tests/test-data/utilities.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps-engine/src/definition/accessors/IMediaCallRead.tsapps/meteor/tests/end-to-end/api/media-calls.tspackages/models/src/models/MediaCalls.tspackages/apps-engine/src/definition/accessors/IRead.tspackages/apps/tests/test-data/bridges/mediaCallBridge.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/accessors/MediaCallRead.tsapps/meteor/app/apps/server/bridges/mediaCalls.tsapps/meteor/app/apps/server/bridges/bridges.jspackages/apps/deno-runtime/lib/accessors/mod.tspackages/apps-engine/src/definition/mediaCalls/IMediaCall.tspackages/apps/src/server/accessors/Reader.tsapps/meteor/server/startup/callHistoryTestData.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/apps/tests/test-data/bridges/appBridges.ts
🧠 Learnings (7)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
packages/apps/tests/server/accessors/Reader.test.tspackages/apps/src/AppsEngine.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/managers/AppAccessorManager.tsapps/meteor/app/api/server/v1/media-calls.tspackages/apps/tests/test-data/utilities.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps-engine/src/definition/accessors/IMediaCallRead.tsapps/meteor/tests/end-to-end/api/media-calls.tspackages/models/src/models/MediaCalls.tspackages/apps-engine/src/definition/accessors/IRead.tspackages/apps/tests/test-data/bridges/mediaCallBridge.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/accessors/MediaCallRead.tsapps/meteor/app/apps/server/bridges/mediaCalls.tspackages/apps/deno-runtime/lib/accessors/mod.tspackages/apps-engine/src/definition/mediaCalls/IMediaCall.tspackages/apps/src/server/accessors/Reader.tsapps/meteor/server/startup/callHistoryTestData.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/apps/tests/test-data/bridges/appBridges.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
packages/apps/tests/server/accessors/Reader.test.tspackages/apps/src/AppsEngine.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/managers/AppAccessorManager.tsapps/meteor/app/api/server/v1/media-calls.tspackages/apps/tests/test-data/utilities.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps-engine/src/definition/accessors/IMediaCallRead.tsapps/meteor/tests/end-to-end/api/media-calls.tspackages/models/src/models/MediaCalls.tspackages/apps-engine/src/definition/accessors/IRead.tspackages/apps/tests/test-data/bridges/mediaCallBridge.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/accessors/MediaCallRead.tsapps/meteor/app/apps/server/bridges/mediaCalls.tspackages/apps/deno-runtime/lib/accessors/mod.tspackages/apps-engine/src/definition/mediaCalls/IMediaCall.tspackages/apps/src/server/accessors/Reader.tsapps/meteor/server/startup/callHistoryTestData.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/apps/tests/test-data/bridges/appBridges.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
packages/apps/tests/server/accessors/Reader.test.tspackages/apps/src/AppsEngine.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/managers/AppAccessorManager.tsapps/meteor/app/api/server/v1/media-calls.tspackages/apps/tests/test-data/utilities.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps-engine/src/definition/accessors/IMediaCallRead.tsapps/meteor/tests/end-to-end/api/media-calls.tspackages/models/src/models/MediaCalls.tspackages/apps-engine/src/definition/accessors/IRead.tspackages/apps/tests/test-data/bridges/mediaCallBridge.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/accessors/MediaCallRead.tsapps/meteor/app/apps/server/bridges/mediaCalls.tspackages/apps/deno-runtime/lib/accessors/mod.tspackages/apps-engine/src/definition/mediaCalls/IMediaCall.tspackages/apps/src/server/accessors/Reader.tsapps/meteor/server/startup/callHistoryTestData.tsee/packages/media-calls/src/server/CallDirector.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tspackages/core-typings/src/mediaCalls/IMediaCall.tspackages/apps/tests/test-data/bridges/appBridges.ts
📚 Learning: 2026-05-11T21:46:23.471Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 40463
File: packages/apps/src/lib/SecureFields.ts:17-19
Timestamp: 2026-05-11T21:46:23.471Z
Learning: In Rocket.Chat’s `packages/apps/tsconfig.json`, TypeScript `"strict"` is set to `false`, which disables strict type-checking (including `noImplicitAny`) for `packages/apps`. When reviewing, do not flag TS7053 (and similar strict-mode indexing/type errors) in files under `packages/apps/src/` that are a consequence of this relaxed strictness—e.g., patterns like indexing an `unknown`/`object` via optional chaining such as `object?.[kSecureFields]`.
Applied to files:
packages/apps/src/AppsEngine.tspackages/apps/src/server/bridges/MediaCallBridge.tspackages/apps/src/server/managers/AppAccessorManager.tspackages/apps/src/server/bridges/AppBridges.tspackages/apps/src/server/bridges/index.tspackages/apps/src/server/permissions/AppPermissions.tspackages/apps/src/server/accessors/index.tspackages/apps/src/server/accessors/MediaCallRead.tspackages/apps/src/server/accessors/Reader.ts
📚 Learning: 2026-02-23T17:53:06.802Z
Learnt from: ggazzo
Repo: RocketChat/Rocket.Chat PR: 35995
File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112
Timestamp: 2026-02-23T17:53:06.802Z
Learning: During PR reviews that touch endpoint files under apps/meteor/app/api/server/v1, enforce strict scope: if a PR targets a specific endpoint (e.g., rooms.favorite), do not propose changes to unrelated endpoints (e.g., rooms.invite) unless maintainers explicitly request them. Focus feedback on the touched endpoint's behavior, API surface, and related tests; avoid broad cross-endpoint changes in the same PR unless requested.
Applied to files:
apps/meteor/app/api/server/v1/media-calls.ts
📚 Learning: 2026-02-24T19:09:01.522Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:01.522Z
Learning: In Rocket.Chat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1, avoid introducing logic changes. Only perform scope-tight changes that preserve behavior; style-only cleanups (e.g., removing inline comments) may be deferred to follow-ups to keep the migration PR focused.
Applied to files:
apps/meteor/app/api/server/v1/media-calls.ts
📚 Learning: 2026-05-06T20:47:53.078Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 40186
File: apps/meteor/app/apps/server/bridges/uiInteraction.ts:2-2
Timestamp: 2026-05-06T20:47:53.078Z
Learning: Deep imports must be used in this repository because Meteor’s bundler does not respect package.json exports subpath mappings. Import using deep paths (e.g., rocket.chat/apps/dist/server/bridges/UiInteractionBridge) instead of relying on exports. Do not suggest or apply changes to exports maps in Meteor-consuming packages (e.g., packages/apps/package.json) as a fix for deep imports. This guideline applies to all TypeScript files under apps/meteor/app/apps/server/bridges.
Applied to files:
apps/meteor/app/apps/server/bridges/mediaCalls.ts
🪛 Biome (2.4.15)
apps/meteor/app/apps/server/bridges/bridges.js
[error] 17-17: Illegal use of an import declaration outside of a module
(parse)
🔇 Additional comments (26)
apps/meteor/app/apps/server/bridges/bridges.js (1)
17-17: LGTM!Also applies to: 65-65, 180-182
apps/meteor/app/apps/server/bridges/mediaCalls.ts (1)
1-16: LGTM!apps/meteor/app/api/server/v1/media-calls.ts (1)
214-251: LGTM!Also applies to: 255-276
apps/meteor/tests/end-to-end/api/media-calls.ts (1)
1-115: LGTM!packages/apps/src/server/permissions/AppPermissions.ts (1)
132-134: LGTM!packages/apps-engine/src/definition/mediaCalls/IMediaCall.ts (1)
1-41: LGTM!packages/core-typings/src/mediaCalls/IMediaCall.ts (1)
72-72: LGTM!packages/apps-engine/src/definition/accessors/IMediaCallRead.ts (1)
1-15: LGTM!packages/apps-engine/src/definition/accessors/IRead.ts (1)
6-6: LGTM!Also applies to: 59-59
packages/apps/src/AppsEngine.ts (1)
11-11: LGTM!packages/models/src/models/MediaCalls.ts (1)
92-95: LGTM!Also applies to: 108-108
ee/packages/media-calls/src/server/CallDirector.ts (1)
27-27: LGTM!Also applies to: 65-70, 242-242
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts (1)
108-108: LGTM!apps/meteor/server/startup/callHistoryTestData.ts (2)
203-203: LGTM!
237-237: LGTM!packages/apps/src/server/bridges/MediaCallBridge.ts (1)
1-33: LGTM!packages/apps/src/server/bridges/AppBridges.ts (1)
15-15: LGTM!Also applies to: 56-57, 115-117
packages/apps/src/server/bridges/index.ts (1)
17-17: LGTM!Also applies to: 39-39
packages/apps/src/server/managers/AppAccessorManager.ts (1)
25-25: LGTM!Also applies to: 196-197, 216-216
packages/apps/src/server/accessors/Reader.ts (1)
6-6: LGTM!Also applies to: 38-38, 101-103
packages/apps/src/server/accessors/index.ts (1)
12-12: LGTM!Also applies to: 62-62
packages/apps/deno-runtime/lib/accessors/mod.ts (1)
257-257: LGTM!packages/apps/tests/server/accessors/Reader.test.ts (1)
9-9: LGTM!Also applies to: 41-47, 49-66, 78-78
packages/apps/tests/test-data/bridges/appBridges.ts (1)
15-15: LGTM!Also applies to: 40-40, 115-116, 146-146, 261-263
packages/apps/tests/test-data/bridges/mediaCallBridge.ts (1)
1-9: LGTM!packages/apps/tests/test-data/utilities.ts (1)
9-9: LGTM!
d-gubert
reviewed
May 29, 2026
d-gubert
reviewed
May 29, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 2, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 3, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 3, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 3, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 3, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 3, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 5, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 5, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 8, 2026
d-gubert
reviewed
Jun 8, 2026
ggazzo
pushed a commit
that referenced
this pull request
Jun 9, 2026
d-gubert
changed the title
d-gubert
force-pushed
the
feat/sip-metadata
branch
from
d2a38c3 to
bbd7101
Compare
coderabbitai
Bot
added
type: feature
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
d-gubert
force-pushed
the
feat/sip-metadata
branch
from
56e3c52 to
a907d37
Compare
coderabbitai
Bot
removed
the
type: feature
d-gubert
force-pushed
the
feat/sip-metadata
branch
from
a907d37 to
13f3355
Compare
d-gubert
force-pushed
the
feat/sip-metadata
branch
from
13f3355 to
243bdbc
Compare
ggazzo
pushed a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
DMV-13
Steps to test or reproduce
Further comments
#40863
Summary by CodeRabbit
New Features
Tests