fix: expired session not redirecting to login page#40849
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 4909a0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40849 +/- ##
===========================================
- Coverage 70.19% 69.86% -0.34%
===========================================
Files 3340 3390 +50
Lines 123638 125109 +1471
Branches 22055 22575 +520
===========================================
+ Hits 86789 87402 +613
- Misses 33507 34310 +803
- Partials 3342 3397 +55
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9f7a1ef to
c9b98fe
Compare
72baa2b to
07115f7
Compare
SUP-1052
Proposed changes (including videos or screenshots)
When a session expires the user is not taken to the login page.
When a user's login token is deleted from the database (expired after 7 days, admin action, etc), the client still has the token in localStorage. When the user tries to perform actions (open room, send message), the app receives 401 errors but stays in a "pending" state instead of redirecting to the login page.
Solution:
ddpOverREST.tsfor DDP method callsRestApiClient.tsfor direct REST API callsIssue(s)
Steps to test or reproduce
Further comments